482441 - 31 days is too short a query for regression hunting, increase search range to 3-4 months

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Wayne Mery (:wsmwk)]

31 days is too short a query for serious regression hunting. If I have to go back more than a couple months the process is labor intensive.  

A low cost query - like choosing just one or two versions, or exact match - should permit a longer search period.

Comment 1

[Ludovic Hirlimann [:Usul]]

I agree with Wayne, 31 days is very short. A good limit would be 2 to 4 months. The cost of querying is very small compared to the cost it would take for a human to hunt down regressions without tooling for older then 31 day crashes.

Comment 2

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #1)
> I agree with Wayne, 31 days is very short. A good limit would be 2 to 4 months.
> The cost of querying is very small compared to the cost it would take for a
> human to hunt down regressions without tooling for older then 31 day crashes.

Agreed - though the admins would have to worry about the larger amount of data to keep. +1 to 2-4 months.

Comment 3

[Austin King [:ozten]]

We should update this bug as we work on the LDAP auth UI, which expands the limits of search for authenticated users.

It raises the issue of which LDAP sources to use, so we can include community members easily.

Comment 4

[Wayne Mery (:wsmwk)]

Can we increase the range for "exact match", which is very efficient, until this cloud thing comes about?  

I can take tedious, but the time required to hunt regression ranged one month at the time is not productive. Longer range would also make graphing and other time based hints more useful.

Comment 5

[Wayne Mery (:wsmwk)]

ozten, what group does one request to get this capability, now that ldap auth is possible via bug 522349?

Comment 6

[Austin King [:ozten]]

This is a feature we need to build into the crash reporter.

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to comment #6)
> This is a feature we need to build into the crash reporter.

How could this need to be implemented on the client whilst we do the queries on the server ?

Comment 8

[Austin King [:ozten]]

(In reply to comment #7)
flagging 1.7. We'll discuss with Socorro team at large to see if we can pull this into the upcoming 1.7 release.

Basically this would allow a larger search window for authorized users.

@wsmwk, @tsk do you already have Socorro admin permissions? 

If not, and if we need to create a different authorization role for this feature, then there is a bit more work involved.

Comment 9

[Wayne Mery (:wsmwk)]

(In reply to comment #8)
> @wsmwk, @tsk do you already have Socorro admin permissions? 

yes. I can get to http://crash-stats.mozilla.com/admin/branch_data_sources and http://crash-stats.mozilla.com/admin/  and email addresses in crash reports.
 
> If not, and if we need to create a different authorization role for this
> feature, then there is a bit more work involved.

FWIW iirc there was talk of having a role between admin and unpriv user. We may have people who could use such a role, but it's certainly not critical.

Comment 11

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 482441

Logged-in users will have the ability to perform queries with a date range of up to 120 days.  At least 1 product must be selected in order to perform a query with a date range greater than 30 days.  Upon query form submit, the query form button will be replaced with a progress button, and the F5 key will be disabled.

If the user performs a query that is outside of the allowed query range, an error will be displayed to the user and the default query date range will be applied to the query (currently 14 days).  Yes, the error message is displayed improperly above the query box - I think I'll need to fix this in the next release.

Comment 12

[Austin King [:ozten]]

Comment on attachment 445158 [details] [diff] [review]
Patch 1 for 482441

Overall this looks really good.

Why remove the Warning message from the prose area? We should leave it or do something better.

I don't think we should use the term 'Super user'. Maybe 'Admin user'? or 'Logged In User'

r- for JS. Isn't binding to the form submit sufficient? It would handle the keyboard vs click vs other wacky way to submit. We should then handle the success and there error case.

Comment 13

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 2 for 482441

Good call Austin.  JS updated.

Changed text to read "admin" instead of "super user".

The warning text is displayed on the page, but in the yellow warning box atop the page.  I felt like the warning text in the prose area didn't stand out enough.  The prose warning can be re-added if necessary.

Comment 14

[Austin King [:ozten]]

Comment on attachment 445252 [details] [diff] [review]
Patch 2 for 482441

Great work!

Comment 15

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Thanks Austin.  Committing.  Will update rollout docs and create a ticket to update config file on stage.

==

Sending        webapp-php/application/config/application.php-dist
Sending        webapp-php/application/controllers/query.php
Sending        webapp-php/application/controllers/report.php
Sending        webapp-php/application/libraries/MY_SearchReportHelper.php
Sending        webapp-php/application/views/common/prose_params.php
Sending        webapp-php/application/views/common/query_form.php
Sending        webapp-php/application/views/layout.php
Sending        webapp-php/css/screen.css
Sending        webapp-php/js/socorro/query.js
Transmitting file data .........
Committed revision 2082.