Closed
Bug 482455
Opened 15 years ago
Closed 15 years ago
Tests from bug 445886 (test_unicode_noncharacters_utf8.html, say) failing randomly
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: bzbarsky, Assigned: smontagu)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
5.61 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This morning: *** 42317 ERROR TEST-UNEXPECTED-FAIL | /tests/intl/uconv/tests/test_unicode_noncharacters_gb18030.html | Error thrown during test: $("display") is null - got 0, expected 1 *** 42320 ERROR TEST-UNEXPECTED-FAIL | /tests/intl/uconv/tests/test_unicode_noncharacters_utf8.html | Error thrown during test: $("display") is null - got 0, expected 1 Looking at the tests, it looks like they assume that 100ms will be enough time to parse the HTML between the script end and the <p id="display">. Clearly that's false in this case for whatever reason. That said, is there a reason the test is using setTimeout at all instead of just running the test from onload?
Reporter | ||
Comment 1•15 years ago
|
||
And while we're here, is there a reason to use: ok($("display").innerHTML == "All good.", "Noncharacters not stripped"); instead of: is($("display").innerHTML, "All good.", "Noncharacters not stripped"); ? The latter produces much more useful output (e.g. the actual value of innerHTML) when it fails.
Comment 2•15 years ago
|
||
Ftr, this build had { /builds/moz2_slave/mozilla-central-linux-unittest/build/js/src/configure: line 2574: echo: write error: Broken pipe }
Comment 3•15 years ago
|
||
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1236682925.1236690074.19396.gz Linux mozilla-central unit test on 2009/03/10 04:02:05
Reporter | ||
Comment 5•15 years ago
|
||
Comment on attachment 366557 [details] [diff] [review] Patch Looks reasonable, assuming this is still testing what you wanted to test.
Attachment #366557 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/8378b438aa5c (In reply to comment #5) > Looks reasonable, assuming this is still testing what you wanted to test. Yeah, I confirmed this by introducing bugs into the converters to see if the tests failed in the expected manner.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•15 years ago
|
Flags: in-testsuite+
Target Milestone: --- → mozilla1.9.2a1
Updated•14 years ago
|
Whiteboard: [orange]
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
You need to log in
before you can comment on or make changes to this bug.
Description
•