Closed Bug 482482 Opened 13 years ago Closed 13 years ago

Migrate version comparator tests to xpcshell

Categories

(Core :: XPCOM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch rev 1 (obsolete) — Splinter Review
The current version comparator tests use a custom executable and a perl script to drive it. We can do just as well with xpcshell.

This copies the test to a simple xpcshell test. It does slightly more tests than the old method. It tests every combination from the comparison arrays verifying that they all give the expected result.
Attachment #366575 - Flags: review?(benjamin)
Comment on attachment 366575 [details] [diff] [review]
patch rev 1

Wait I just remembered that xpcshell isn't mochitest
Attachment #366575 - Attachment is obsolete: true
Attachment #366575 - Flags: review?(benjamin)
Attached patch patch rev 2Splinter Review
Should actually report failures in the log this time.
Attachment #366577 - Flags: review?(benjamin)
Attachment #366577 - Flags: review?(benjamin) → review+
Landed:
http://hg.mozilla.org/mozilla-central/rev/10a0a1062f3a
http://hg.mozilla.org/mozilla-central/rev/6475fbc83841
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
You need to log in before you can comment on or make changes to this bug.