482556 - Request password reset is harder to access

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Guy Pyrzak]

With the new login at the top of the screen it is much harder to request a password reset. Two options are to have something on the error page OR something on the page directly since some users might know they forgot but not be sure how to get to it.

Comment 1

[Frédéric Buclin]

(In reply to comment #0)
> With the new login at the top of the screen it is much harder to request a
> password reset.

I agree, and we should try to fix this before 3.4rc1. I would tend to say it's a blocker.

Comment 2

[Max Kanat-Alexander]

Yes, this is a blocker. We should modify the error message at the very least, and then if we also come up with some clever solution that doesn't involve taking up any more horizontal space with the form, we can do that also.

Comment 3

[Max Kanat-Alexander]

We could also just put a link on the home page for logged-out users, I think that would work.

Comment 4

[Frédéric Buclin]

Could we get some traction on this bug? It's the last blocker without a patch.

Comment 5

[mao]

Maybe I can try to add this patch.
My solution is:
1. add "forgot password" link after "login" button. it will link to reset password request.
2. add reset password request section in the error page which user input invalid user name or password

Comment 6

[Guy Pyrzak]

Attachment: Patch v1

here is my first attempt sorry it took so long!

Comment 7

[Frédéric Buclin]

Comment on attachment 373002 [details] [diff] [review]
Patch v1

It looks good, but something is broken with the following STR:

1. Click the "forgot password" link
2. Enter wrong credentials
3. Click the "click here" link in the error message

The error message doesn't go away.

Comment 8

[Guy Pyrzak]

Attachment: Zip of the new Login UI with the forget button being easy to access

Please note that I'll still use the old capability that we have in the current version to detect if the autofill is working, if it does work, then i will assume you are going to log in and not reset your password. Let me know what you guys think. I wanted to do something smart here for people who like the current UI that lets you login with 1 click.

Comment 9

[Max Kanat-Alexander]

Comment on attachment 373255 [details]
Zip of the new Login UI with the forget button being easy to access

Sweet, looks nice! :-) Make sure it still works for people who have JS disabled (even if it looks terrible).

Comment 10

[Frédéric Buclin]

This is the last blocker with no patch. pyrzak?

Comment 11

[Guy Pyrzak]

I'm trying to get to this along with all my reviews. Feel free to supply your own patch for the design supplied if you have the time to write it.

Comment 12

[Max Kanat-Alexander]

Attachment: v2

This is pretty much pyrzak's design with one addition--a little [x] next to both forms that allows you to close them so that you can get back to the state you were in before. This is important in case you want to create a new account even though you've shown the login form (or even though the login form has been automatically shown because you have stuff in there).

Also, "Forgot Password" still shows when the login form is showing, because you might go to the login form and only *then* realize you've forgotten your password.

There's very little JS in here (and it's all pretty much repetitive and doesn't need review) so I'm asking LpSolit for review.

Comment 13

[Frédéric Buclin]

Comment on attachment 378150 [details] [diff] [review]
v2

>Index: template/en/default/global/common-links.html.tmpl

>+      <li id="new_account_container[% qs_suffix %]">

Must be HTML filtered:

#   Failed test '(en/default) template/en/default/global/common-links.html.tmpl has unfiltered directives:
#   89: qs_suffix
# --ERROR'


Otherwise looks good and works fine. r=LpSolit

Comment 14

[Max Kanat-Alexander]

Did the checkin fix. Thanks for the review! :-)

tip:

Checking in js/global.js;
/cvsroot/mozilla/webtools/bugzilla/js/global.js,v  <--  global.js
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.18; previous revision: 1.17
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.21; previous revision: 1.20
done

3.4:

Checking in js/global.js;
/cvsroot/mozilla/webtools/bugzilla/js/global.js,v  <--  global.js
new revision: 1.2.2.1; previous revision: 1.2
done
Checking in template/en/default/account/auth/login-small.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/account/auth/login-small.html.tmpl,v  <--  login-small.html.tmpl
new revision: 1.17.2.1; previous revision: 1.17
done
Checking in template/en/default/global/common-links.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/common-links.html.tmpl,v  <--  common-links.html.tmpl
new revision: 1.20.2.1; previous revision: 1.20
done