MemoryProfiler missing some frees

VERIFIED FIXED

Status

Tamarin
Garbage Collection (mmGC)
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Erik Tierney, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Created attachment 366661 [details] [diff] [review]
Switch GCLargeAlloc::Finalize to call FinalizeHook rather than FreeHook

MemoryProfiler was reporting much higher numbers for stack traces than it reported for total memory used.  Turns out we were missing a call to FinalizeHook in GCLargeAlloc::Finalize.  It was calling FreeHook, but that doesn't decrement the size/count for the stack trace.
Attachment #366661 - Flags: review?(treilly)

Updated

9 years ago
Attachment #366661 - Flags: review?(treilly) → review+
(Reporter)

Comment 1

9 years ago
Pushed:  http://hg.mozilla.org/tamarin-redux/rev/36c6de82dce4
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 2

9 years ago
Resolved fixed engineering / work item that has been pushed.  Setting status to verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.