482618 - Home page should only feature public discussions

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[krupa raj[:krupa]]

Steps to reproduce:
1.Go to https://spreadfirefox.authstage.mozilla.com/.Do not log in.
2.Under recent discussion click on "Re: 38 here is a little problem with" topic

Expected result:
All featured discussions are public in nature.On clicking the link in the homepage,the discussion page loads.


Actual result:
Discussion topics which are privy to members of certain projects are listed under "Recent discussions".

Comment 1

[Mary]

This is pretty important :)

Comment 2

[Alex Buchanan [:abuchanan]]

Ah, I didn't factor in that we have private, members-only groups.  That could make gathering these a lot more difficult, I'm not sure how to pull that from the DB.  

Paul, do you know how OG tracks which groups are members-only?

Comment 3

[Paul Booker]

The 'og' table tracks group nodes and whether their private.

Comment 4

[Paul Booker]

Unassigning myself from this bug just in case 
Alex wan to pick this up later today.

Comment 5

[Paul Booker]

Also you can have a public group where some of the content is private. This is achieved with the is_public field in the og_ancestry table this table associates individual nodes with group nodes. Also its probably worth mentioning here that the table og_uid associates subscribers with groups.

Comment 6

[Paul Booker]

As these are discussions (forum topics) then its the table og_terms that is important here as it is this table that links group nodes 'nid' with the forums taxonomy term id  'tid' and here there is another 'public' field which controls where the discussion node is public / private.

Comment 7

[Mary]

Ok -- I'm gonna assign to Buchanan....I think he has an idea on this one.

Comment 8

[Alex Buchanan [:abuchanan]]

OK, I think I've got this working as of r23567.  Sorry for the delay, it turned out to be trickier than I thought.  

The list will update with each cron run, because the query for sorting discussions/comments is too heavy to be run for every load of the home page.

You can run cron manually by going to...
https://spreadfirefox.authstage.mozilla.com/admin/logs/status/run-cron

Comment 9

[krupa raj[:krupa]]

Currently ,a non-logged in user gets "access denied" page on clicking featured content in recent discussion section.
Reopening....

Comment 10

[Alex Buchanan [:abuchanan]]

per bug 484273...

OK, sorry for the back and forth on this one.  I think I've finally got it figured out.  "Untitled" and other private groups no longer show up.

r23723

Comment 11

[krupa raj[:krupa]]

Currently only public discussions are listed in this section.So I am going
ahead and marking this verified.Will reopen if I notice any anomalies.