change 'Privacy' tab to 'Security'

RESOLVED FIXED in Thunderbird 3.0b3

Status

Thunderbird
Preferences
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: clarkbw, Assigned: clarkbw)

Tracking

Trunk
Thunderbird 3.0b3
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The 'Privacy' tab in Thunderbird preferences doesn't describe the elements it provides very well at all.  Firefox has started to use a security for the tab that contains passwords.  In bug 482617 we will be moving the Junk tab out of privacy and into it's own tab, making the current 'Privacy' tab about passwords, viruses, and phishing; a fun trio that play well together.

Will attach working patch soon.
Flags: blocking-thunderbird3+
(Assignee)

Comment 1

9 years ago
Just to note that the change made by bug 368635 left the function called by the oncommand handler broken; I'm going to remove the handler in this patch so it doesn't error anymore.
(Assignee)

Comment 2

9 years ago
lets get this change in first, I'm using the privacy/security icon from the tango preferences for both win/lin
Blocks: 482610
(Assignee)

Comment 3

9 years ago
Created attachment 366721 [details] [diff] [review]
version 1 privacy -> security

magnus: you're my go-to linux reviewer :)

I've done an hg rename of mail/components/preferences/privacy.* -> security.*

removed themes/(qute|gnomestripe)/mail/preferences/privacy.png
added themes/(qute|gnomestripe)/mail/preferences/security.png from attachment 366669 [details]

renamed mail/locales/en-US/chrome/messenger/preferences/privacy.dtd -> security.dtd

cleaned out all references to privacy.js, privacy.png, and other privacy* css rules in all 3 themes.

I left the pref pref.privacy.disable_button.view_passwords as is because there already exists a number of docs online for how to change the view passwords button to disabled and don't think it's needed to remove the word privacy from that pref.

also included the one line fix for bug 368635
Attachment #366721 - Flags: review?(mkmelin+mozilla)

Comment 4

9 years ago
Comment on attachment 366721 [details] [diff] [review]
version 1 privacy -> security

Looks good to me! r=mkmelin
Attachment #366721 - Flags: review?(mkmelin+mozilla) → review+
(Assignee)

Comment 5

9 years ago
thanks magnus!
Status: NEW → ASSIGNED
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/92b814189264
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.