482635 - The localstore.json files should be created in the user profile rather than in the webapp folders

Status: RESOLVED FIXED

(Mozilla Labs :: Prism, defect)

Description

[Romain Huet]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; fr; rv:1.9.0.7) Gecko/2009021906 Firefox/3.0.7
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020412 Prism/0.9.1

Before closing, a Prism application saves the user configuration in a localstore.json file. This file contains UI data, namely the size and the position of the Prism window.

However, this file is always written the webapp folder rather than in the user profile.

Reproducible: Always

Steps to Reproduce:
1. Run a Prism application from any webapp folder using the following command:
   $ prism -webapp /path/to/webapp/folder
2. Close the Prism application.
3. Check where the localstore.json file is created.

Actual Results:  
The localstore.json file is created in the webapp folder, which means it is shared between all the users.

Expected Results:  
The localstore.json file should be created in the user profile as this information is related to his or her personal use of the application.

If the localstore.json cannot be written, which is the case when the user do not have the correct access rights on the webapp folder, Prism will not remember the window properties and the bug described in the following report will also still appear: https://bugzilla.mozilla.org/show_bug.cgi?id=478201.

Comment 1

[Matthew Gertner]

Attachment: Move localstore.json to profile directory

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 375019 [details] [diff] [review]
Move localstore.json to profile directory

Maybe you could add a WebAppProperties.getProfileRoot() ?

Maybe in a followup.

Comment 3

[Matthew Gertner]

Sending        chrome/content/webrunner.js
Transmitting file data .
Committed revision 25219.