Make Mac button size dependent on their font size

RESOLVED FIXED in mozilla1.9.2a1

Status

()

Toolkit
Themes
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

({polish})

Trunk
mozilla1.9.2a1
All
Mac OS X
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 366778 [details] [diff] [review]
fix v1

Right now, normal Mac aqua buttons are always 22px high, regardless of their font size. So if a button is in a window with font: message-box, there's small-sized text on a regular-sized button.
This doesn't look good.

This patch removes the min-height and adds vertical margin to the button text so that the button size is always right.

I'm also removing the padding on the button because it doesn't have any effect.

With this patch, the "Clear" button in the Downloads window will be higher than before, but I'll fix this in bug 477827 before I land this one.

Mano, since you were also involved in bug 354947, bug 376816 and bug 379297, could you have a quick look at this patch?
Attachment #366778 - Flags: review?(mano)
(Assignee)

Comment 1

9 years ago
Created attachment 366779 [details]
screenshot after
Did you test button-image, button-small, etc?
(Assignee)

Comment 3

9 years ago
Created attachment 375485 [details] [diff] [review]
v2

What's button-small?
I've tested button-image, the patch doesn't break it (afaict).

I've made two small changes to the patch: the horizontal margin for .button-text was unnecessary. Moreover, in notification bar buttons, the margins need to be reset.
Attachment #366778 - Attachment is obsolete: true
Attachment #375485 - Flags: review?(mano)
Attachment #366778 - Flags: review?(mano)
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 5

9 years ago
http://hg.mozilla.org/mozilla-central/rev/04f5a3303ebf
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
(Assignee)

Comment 6

9 years ago
Backed out because it broke the test from bug 371080. This was obvious, I should have thought about it before landing.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

9 years ago
Created attachment 382708 [details] [diff] [review]
replace flawed mochitest with a proper reftest
Attachment #382708 - Flags: superreview?(roc)
Attachment #382708 - Flags: review?(dao)
(Assignee)

Updated

9 years ago
Status: REOPENED → ASSIGNED
Attachment #382708 - Flags: superreview?(roc) → superreview+

Updated

9 years ago
Attachment #382708 - Flags: review?(dao) → review+
(Assignee)

Comment 8

9 years ago
http://hg.mozilla.org/mozilla-central/rev/9a3cf1d3c372
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.