482681 - Make Mac button size dependent on their font size

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix v1

Right now, normal Mac aqua buttons are always 22px high, regardless of their font size. So if a button is in a window with font: message-box, there's small-sized text on a regular-sized button.
This doesn't look good.

This patch removes the min-height and adds vertical margin to the button text so that the button size is always right.

I'm also removing the padding on the button because it doesn't have any effect.

With this patch, the "Clear" button in the Downloads window will be higher than before, but I'll fix this in bug 477827 before I land this one.

Mano, since you were also involved in bug 354947, bug 376816 and bug 379297, could you have a quick look at this patch?

Comment 1

[Markus Stange [:mstange]]

Attachment: screenshot after

Comment 2

[Asaf Romano (gone)]

Did you test button-image, button-small, etc?

Comment 3

[Markus Stange [:mstange]]

Attachment: v2

What's button-small?
I've tested button-image, the patch doesn't break it (afaict).

I've made two small changes to the patch: the horizontal margin for .button-text was unnecessary. Moreover, in notification bar buttons, the margins need to be reset.

Comment 4

[Asaf Romano (gone)]

Comment on attachment 375485 [details] [diff] [review]
v2

ok, r=mano

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/04f5a3303ebf

Comment 6

[Markus Stange [:mstange]]

Backed out because it broke the test from bug 371080. This was obvious, I should have thought about it before landing.

Comment 7

[Markus Stange [:mstange]]

Attachment: replace flawed mochitest with a proper reftest

Comment 8

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/9a3cf1d3c372