Closed
Bug 482718
Opened 15 years ago
Closed 15 years ago
Remove toolkit history remnants in libxul build, left by bug 383833
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.2a1
People
(Reporter: standard8, Assigned: standard8)
References
Details
(Keywords: fixed1.9.1)
Attachments
(1 file)
792 bytes,
patch
|
ted
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
Bug 383833 removed toolkit/components/history from the build but missed removing the libxul library inclusions in toolkit/library. This means if your app builds with mork, you're not going to be able to build with --enable-libxul.
Assignee | ||
Comment 1•15 years ago
|
||
Removes the unnecessary items.
Attachment #367034 -
Flags: review?
Assignee | ||
Updated•15 years ago
|
Attachment #367034 -
Flags: review? → review?(ted.mielczarek)
Updated•15 years ago
|
Attachment #367034 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Checked in: http://hg.mozilla.org/mozilla-central/rev/7c6ef292bca3
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Assignee | ||
Comment 3•15 years ago
|
||
Comment on attachment 367034 [details] [diff] [review] The fix Requesting 1.9.1 branch approval. Build config patch only so should be low risk. If anyone is trying to build a libxul app with mork enabled, then they will want this patch.
Attachment #367034 -
Flags: approval1.9.1?
Comment 5•15 years ago
|
||
Comment on attachment 367034 [details] [diff] [review] The fix a191=beltzner
Attachment #367034 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 6•15 years ago
|
||
Landed on 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/921811b34c80
Flags: in-testsuite-
Keywords: fixed1.9.1
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•