Closed
Bug 482733
Opened 15 years ago
Closed 15 years ago
nsinstall.py should support copying directories recursively
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ted, Assigned: ted)
References
Details
(Keywords: fixed1.9.1)
Attachments
(3 files, 1 obsolete file)
10.20 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
2.73 KB,
patch
|
Pike
:
review+
|
Details | Diff | Splinter Review |
6.96 KB,
patch
|
Details | Diff | Splinter Review |
Apparently the in-tree nsinstall.c gained the ability to recursively copy directories sometime back in 2001. nsinstall.py does not have this ability, but it should.
Assignee | ||
Comment 1•15 years ago
|
||
This just refactors nsinstall.py into a main nsinstall() method, and adds some simple unit tests. I'll actually fix the bug in a followup patch.
Attachment #366869 -
Flags: review?(l10n)
Assignee | ||
Comment 2•15 years ago
|
||
Added a unittest for -m (not on windows), and got rid of the Windows line endings. (ew)
Attachment #366869 -
Attachment is obsolete: true
Attachment #366917 -
Flags: review?(l10n)
Attachment #366869 -
Flags: review?(l10n)
Assignee | ||
Comment 3•15 years ago
|
||
Ok, actual bugfix, with a new unit test to test it.
Attachment #366919 -
Flags: review?(l10n)
Comment 4•15 years ago
|
||
Comment on attachment 366917 [details] [diff] [review] refactor + unittets, rev 2 I know that hg is weak on that, but is a hg diff -w or -b easier to review than this one?
Assignee | ||
Comment 5•15 years ago
|
||
Updated•15 years ago
|
Attachment #366917 -
Flags: review?(l10n) → review+
Comment 6•15 years ago
|
||
Comment on attachment 366919 [details] [diff] [review] fix nsinstall.py to copy directories recursively r+ with nits. Can you rename files to entries? copy_all_files feels strange when you're copying dirs, too. Same for the variable names inside the loops?
Attachment #366919 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 7•15 years ago
|
||
Pushed to m-c: http://hg.mozilla.org/mozilla-central/rev/f01a5fd071f3 http://hg.mozilla.org/mozilla-central/rev/6d2ef6b135fa
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•15 years ago
|
||
And of course I forgot to fix the copy in js/src: http://hg.mozilla.org/mozilla-central/rev/13826ed07169
Assignee | ||
Comment 9•15 years ago
|
||
Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/96ffe2f278be http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a334c11993b4 (I rolled the bustage fix into this commit)
Keywords: fixed1.9.1
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•