482739 - Software keyboard does not activate on password text edit fields

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Doug Turner (:dougt)]

1) go to reader.google.com
2) click in the user name field
3) notice that the software keyboard is displayed
4) click in the password field
5) notice that the software keyboard is not displayed

expected result:
software keyboard to be displayed when entering text into a password text field

Comment 1

[Rob Russell]

I think this is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=480306

Comment 2

[Doug Turner (:dougt)]

it is a dup, but the fix is actually platform specific.


The problem turns out that we are using the wrong nsIWidget IME flags to determine if we should open up the software keyboard.  We should be testing just to see if the IME is disabled, and if it is we should close the software keyboard.  Otherwise, all other states (normal, plugins, password), we should open up the software keyboard.

patch coming up.

Comment 3

[Doug Turner (:dougt)]

Attachment: patch v.1

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 368441 [details] [diff] [review]
patch v.1

>diff --git a/widget/src/windows/nsWindow.cpp b/widget/src/windows/nsWindow.cpp
>+  HWND hWndSIP = FindWindowW(L"SipWndClass", NULL );
>+  if (hWndSIP)
>+    ::ShowWindow( hWndSIP, show ? SW_SHOW: SW_HIDE);

Can you fix up the "( " and  " )" when you land this? Yes, I'm a nut case.

Comment 5

[Doug Turner (:dougt)]

mfinkle, yeah good catch.

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 368441 [details] [diff] [review]
patch v.1

so there are two changes here, one is to pull the code out as a helper function; which is pretty strait forward.

The second is to enable the SIP for passwords, which seems like a good idea.  The question that comes to my mind though is why doesn't the IME code enabled the IME for passwords in general?  i.e. should this change be:

-    PRBool enable = (aState == nsIWidget::IME_STATUS_ENABLED ||
-                     aState == nsIWidget::IME_STATUS_PLUGIN);
+    PRBool enable = aState != nsIWidget::IME_STATUS_DISABLED;


otherwise this looks fine, perhaps Stuart or another peer can weigh in on that though.

Comment 7

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/9f933264db53

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 368441 [details] [diff] [review]
patch v.1

a191=beltzner

Comment 9

[Dão Gottwald [::dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/894d3286f108

Comment 10

[Doug Turner (:dougt)]

clearing wanted flag; this landed on 1.9.1

Comment 11

[Aakash Desai [:aakashd]]

verified FIXED on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv1.9.2a2pre) Gecko/20090810 Fennec/1.0a3pre