Closed Bug 482739 Opened 13 years ago Closed 13 years ago

Software keyboard does not activate on password text edit fields

Categories

(Core :: Widget: Win32, defect)

x86
Windows Mobile 6 Standard
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
fennec 1.0a1-wm+ ---

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

1) go to reader.google.com
2) click in the user name field
3) notice that the software keyboard is displayed
4) click in the password field
5) notice that the software keyboard is not displayed

expected result:
software keyboard to be displayed when entering text into a password text field
Flags: wanted-fennec1.0?
tracking-fennec: --- → 1.0a1-wm+
Assignee: nobody → doug.turner
I think this is a duplicate of https://bugzilla.mozilla.org/show_bug.cgi?id=480306
it is a dup, but the fix is actually platform specific.


The problem turns out that we are using the wrong nsIWidget IME flags to determine if we should open up the software keyboard.  We should be testing just to see if the IME is disabled, and if it is we should close the software keyboard.  Otherwise, all other states (normal, plugins, password), we should open up the software keyboard.

patch coming up.
Attached patch patch v.1Splinter Review
Attachment #368441 - Flags: review?(bugmail)
Attachment #368441 - Flags: superreview?(pavlov)
Comment on attachment 368441 [details] [diff] [review]
patch v.1

>diff --git a/widget/src/windows/nsWindow.cpp b/widget/src/windows/nsWindow.cpp
>+  HWND hWndSIP = FindWindowW(L"SipWndClass", NULL );
>+  if (hWndSIP)
>+    ::ShowWindow( hWndSIP, show ? SW_SHOW: SW_HIDE);

Can you fix up the "( " and  " )" when you land this? Yes, I'm a nut case.
mfinkle, yeah good catch.
Attachment #368441 - Flags: review?(bugmail) → review+
Comment on attachment 368441 [details] [diff] [review]
patch v.1

so there are two changes here, one is to pull the code out as a helper function; which is pretty strait forward.

The second is to enable the SIP for passwords, which seems like a good idea.  The question that comes to my mind though is why doesn't the IME code enabled the IME for passwords in general?  i.e. should this change be:

-    PRBool enable = (aState == nsIWidget::IME_STATUS_ENABLED ||
-                     aState == nsIWidget::IME_STATUS_PLUGIN);
+    PRBool enable = aState != nsIWidget::IME_STATUS_DISABLED;


otherwise this looks fine, perhaps Stuart or another peer can weigh in on that though.
Status: NEW → ASSIGNED
Attachment #368441 - Flags: superreview?(pavlov) → approval1.9.1?
http://hg.mozilla.org/mozilla-central/rev/9f933264db53
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 368441 [details] [diff] [review]
patch v.1

a191=beltzner
Attachment #368441 - Flags: approval1.9.1? → approval1.9.1+
Depends on: 477727
clearing wanted flag; this landed on 1.9.1
Flags: wanted-fennec1.0?
verified FIXED on build:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv1.9.2a2pre) Gecko/20090810 Fennec/1.0a3pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.