Closed Bug 482776 Opened 12 years ago Closed 12 years ago

JarMaker.py unittests don't cause "make check" to fail

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ted, Assigned: Pike)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file)

I noticed that the JarMaker.py unittests are failing on my x86-64 Linux machine, but "make check" was still succeeding. This is bad, they should make it fail.
Taking.

Is just calling

  false;

portable?

And the failure on -64 was that dash doesn't know about ==, but only =. I'll fix that as I go.
Assignee: nobody → l10n
Status: NEW → ASSIGNED
Duplicate of this bug: 483432
Comment on attachment 367044 [details] [diff] [review]
use = instead of ==, and false to fail on tests, with better debug output

This WFM on Ubuntu. Thanks!
Attachment #367044 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/45fc547f59ff, marking FIXED.

I guess that we want this on 1.9.1, too.
Flags: blocking1.9.1?
Not blocking, but we should take it anyway.
Flags: blocking1.9.1? → blocking1.9.1-
Comment on attachment 367044 [details] [diff] [review]
use = instead of ==, and false to fail on tests, with better debug output

a1.9.1+ once it bakes. (green unittests on all platforms should be enough.)
Attachment #367044 - Flags: approval1.9.1+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 490358
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.