482776 - JarMaker.py unittests don't cause "make check" to fail

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(not currently active) Ted Mielczarek]

I noticed that the JarMaker.py unittests are failing on my x86-64 Linux machine, but "make check" was still succeeding. This is bad, they should make it fail.

Comment 1

[Axel Hecht [:Pike]]

Taking.

Is just calling

  false;

portable?

And the failure on -64 was that dash doesn't know about ==, but only =. I'll fix that as I go.

Comment 2

[Axel Hecht [:Pike]]

Attachment: use = instead of ==, and false to fail on tests, with better debug output

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 367044 [details] [diff] [review]
use = instead of ==, and false to fail on tests, with better debug output

This WFM on Ubuntu. Thanks!

Comment 5

[Axel Hecht [:Pike]]

http://hg.mozilla.org/mozilla-central/rev/45fc547f59ff, marking FIXED.

I guess that we want this on 1.9.1, too.

Comment 6

[(not currently active) Ted Mielczarek]

Not blocking, but we should take it anyway.

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 367044 [details] [diff] [review]
use = instead of ==, and false to fail on tests, with better debug output

a1.9.1+ once it bakes. (green unittests on all platforms should be enough.)

Comment 8

[Axel Hecht [:Pike]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/00921829ac6c, fixed1.9.1, too.