48284 - GetUnicodeEncoder returns cached instance

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P3)

Description

[nhottanscp]

When I call GetUnicodeEncoder for ISO-8859-1, I am getting a cached encoder.
For example, mErrBehavior is set to kOnError_Replace that is a different from 
the default value kOnError_Signal.

487   nsCOMPtr<nsIUnicodeEncoder> encoder;
488   if (!strncmp(progid+baselen, NS_1BYTE_CODER_PATTERN, 
NS_1BYTE_CODER_PATTERN_LEN))
489   {
490     // Single byte encoders/decoders dont hold state. Optimize by using a 
service.
491     encoder = do_GetService(progid, &res);
492   }

Comment 1

[nhottanscp]

Nominating for nsbeta3.
By getting a cached encoder, the encoder has states set by someone else.
In the example I mentioned, I cannot do a client side fallback for unmapped 
characters (e.g. transliteration) because the converter internal fallback is 
already set by someone else.

Comment 2

[cata]

DP, you should back out the performance improvement for the encoders: looks like 
the assumption that they are stateless is not true. Keep them for decoders 
though, so far they look ok.

Comment 3

[nhottanscp]

Reassign to nhotta.

Comment 4

[nhottanscp]

Attachment: patch to disable caching for encoders

Comment 5

[Frank Tang]

nsbeta3+ to unblock trudelle's group (pavlov). nsbeta3+ per ftang/jaimejr
r=ftang/cata . check it in.

Comment 6

[nhottanscp]

checked in the patch

Comment 7

[Teruko Kobayashi]

Verified.