PRBool violation in nsTextAttrs.cpp

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: davidb, Assigned: davidb)

Tracking

({access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 367053 [details] [diff] [review]
patch 1

We should not use NS_ENSURE_STATE in methods that return PRBool.
(Caught by Taras Glek's analysis tool)
Attachment #367053 - Flags: review?(surkov.alexander)
Attachment #367053 - Flags: review?(marco.zehe)

Updated

9 years ago
Attachment #367053 - Flags: review?(marco.zehe) → review+

Comment 1

9 years ago
Is this the only spot where we do this, or are there other places in our code that do this and need fixing?
We should get automatic emails from Taras' tool if we do this elsewhere.

Updated

9 years ago
Attachment #367053 - Flags: review?(surkov.alexander) → review+

Comment 3

9 years ago
Comment on attachment 367053 [details] [diff] [review]
patch 1

r=me, thanks

Comment 4

9 years ago
Pushed on Davidb's behalf in changeset:
http://hg.mozilla.org/mozilla-central/rev/9bb687517490
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.