Closed
Bug 482974
Opened 15 years ago
Closed 15 years ago
PRBool violation in nsTextAttrs.cpp
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: davidb, Assigned: davidb)
Details
(Keywords: access)
Attachments
(1 file)
|
1.70 KB,
patch
|
surkov
:
review+
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
We should not use NS_ENSURE_STATE in methods that return PRBool. (Caught by Taras Glek's analysis tool)
Attachment #367053 -
Flags: review?(surkov.alexander)
Attachment #367053 -
Flags: review?(marco.zehe)
|
||
Updated•15 years ago
|
Attachment #367053 -
Flags: review?(marco.zehe) → review+
|
|
||
Comment 1•15 years ago
|
||
Is this the only spot where we do this, or are there other places in our code that do this and need fixing?
|
Assignee | |
Comment 2•15 years ago
|
||
We should get automatic emails from Taras' tool if we do this elsewhere.
|
||
Updated•15 years ago
|
Attachment #367053 -
Flags: review?(surkov.alexander) → review+
|
|
||
Comment 3•15 years ago
|
||
Comment on attachment 367053 [details] [diff] [review] patch 1 r=me, thanks
|
|
||
Comment 4•15 years ago
|
||
Pushed on Davidb's behalf in changeset: http://hg.mozilla.org/mozilla-central/rev/9bb687517490
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•