483005 - [W-1.6.3] Extension Features Page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

Need copy for extension features page to send to Clearleft for design.

Comment 1

[Justin Scott [:fligtar]]

Moving to new M6 milestone. (5/21)

Comment 2

[Justin Scott [:fligtar]]

Attachment: Features page copy

copy for features page

Comment 3

[Justin Scott [:fligtar]]

Attachment: mockup of features page

This is a mockup of what the features page might look like. Note that the copy here is outdated, and should be replaced with the text file previously attached.

Comment 4

[Justin Scott [:fligtar]]

Re-assigning to nobody@ for it to get picked up in this release.

Comment 5

[Jeff Balogh (:jbalogh)]

Attachment: adding the copy for the extension features page

This is just the copy, so we can push it out to localizers.

One question: what do we do about <a href="/collections">?  $this->url isn't available.

Comment 6

[Justin Scott [:fligtar]]

For pages I usually replace the url with %s and then pass the $this->url() in as a parameter to the page. There are some other pages that have examples of this technique.

Comment 7

[Jeff Balogh (:jbalogh)]

Attachment: adding the copy for the extension features page

Thanks fligtar.

Comment 8

[Jeff Balogh (:jbalogh)]

Copy added in r25405.

Comment 9

[Jeff Balogh (:jbalogh)]

Attachment: extension features page; will need CSS tweaking

Comment 10

[Jeff Balogh (:jbalogh)]

I forgot to put in the target for the download button; do we know where that's pointing?

Comment 11

[Justin Scott [:fligtar]]

It will point to the permalink of the xpi. I'll upload the add-on and mark it disabled so we can get the id and link.

Comment 12

[Justin Scott [:fligtar]]

The link will be:
https://addons.mozilla.org/en-US/firefox/downloads/latest/11950/addon-11950-latest.xpi

and should use an installTrigger with the extension icon, found here:

https://addons.mozilla.org/en-US/firefox/images/addon_icon/11950/1242334700

For an example of installTrigger, see app/webroot/services/install.php

Comment 13

[Wil Clouser [:clouserw]]

Comment on attachment 377480 [details] [diff] [review]
extension features page; will need CSS tweaking

In addition to the install button the two links below it aren't going anywhere either.

Comment 14

[Justin Scott [:fligtar]]

a=fligtar on strings, with the exception that "Add-ons Collector Features" should be "Add-on Collector Features"

Comment 15

[Jeff Balogh (:jbalogh)]

Attachment: extension features page with a working Add to Firefox

r?'ing mainly for the changes to install.thtml.  I removed unused variables, documented the parameters, and made some things configurable.  The other parts are the same, but with the TODOs fixed up.

Comment 16

[Wil Clouser [:clouserw]]

Comment on attachment 378489 [details] [diff] [review]
extension features page with a working Add to Firefox

This patch has a little rot but isn't bad.  I'd r+ it but there is something wrong with the layout of the page - the install button is drawing itself below the text.  Screenshot: http://www.pict.com/view/559467/0/addon2520collector2520features25

Comment 17

[Jeff Balogh (:jbalogh)]

Attachment: fixing up some css fail

/**
 * This is a wtf I found on the collector_features page.  If your page looks
 * like
 *   <div class=primary />
 *   <div class=secondary />
 * then the default clear: both on .secondary will put .secondary content
 * *under* .primary, not beside.  It works if you put the .secondary div first
 * in your code, but that's wrong.
 */

Comment 18

[Jeff Balogh (:jbalogh)]

Comment on attachment 378489 [details] [diff] [review]
extension features page with a working Add to Firefox

r? again when paired with attachment 378889 [details] [diff] [review]

Comment 19

[Wil Clouser [:clouserw]]

Comment on attachment 378889 [details] [diff] [review]
fixing up some css fail

I noticed this on one of my pages too.  R+ as long as you add an html-rtl rule that clear's right too.

Comment 20

[Jeff Balogh (:jbalogh)]

r26041.  Note that I didn't add a rule for html-rtl because it's already clear: right in main.css

Comment 21

[Jeff Balogh (:jbalogh)]

QA: make sure you refresh your CSS.

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/pages/collector_features; missing gettext() strings will be taken care of once bug 494119 is fixed.

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

removing "push-needed" from 105 AMO 5.0.6 bugs; filter on "I hate stephend!"