483008 - [W-1.6.5] Extension first-run page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collector Extension, defect)

Description

[Justin Scott [:fligtar]]

Need copy for the extension first-run page to send to Clearleft for designs.

Comment 1

[Justin Scott [:fligtar]]

Moving to new M6 milestone. (5/21)

Comment 2

[Wil Clouser [:clouserw]]

->natbat for designs.  ->lorchard after delivery.

Comment 3

[Justin Scott [:fligtar]]

Attachment: final mockup

This is the mockup that Clearleft is currently implementing.

Comment 4

[Wil Clouser [:clouserw]]

CSS is being added in bug 490887 but we can start on this

Comment 5

[Wil Clouser [:clouserw]]

Natalie says this is delayed until next wednesday.

Comment 6

[Justin Scott [:fligtar]]

Extension download and first-run pages are now available from Clearleft.

Comment 7

[Wil Clouser [:clouserw]]

Attachment: add collector_firstrun

This is a git patch so you can get the image I had to add.  If you need it separately let me know.

Comment 8

[Ryan Doherty (:rdoherty)]

Comment on attachment 379467 [details] [diff] [review]
add collector_firstrun

Looks great except for one small problem.

When not logged in, the 'Get Started with These Collections' bottom dotted border is flush against the collection above it.

Comment 9

[Justin Scott [:fligtar]]

When not logged in, the buttons should go to the login page, with the post-login action adding the collection to favorites.

Comment 10

[Wil Clouser [:clouserw]]

Attachment: new patch

Remove the button for people not logged in

Comment 11

[Wil Clouser [:clouserw]]

(fligtar is fine with this, btw.  I'm not going all broken arrow)

Comment 12

[Ryan Doherty (:rdoherty)]

Comment on attachment 380208 [details] [diff] [review]
new patch

Good work Deak!

Comment 13

[Wil Clouser [:clouserw]]

w00t! r26514

QA: this will be at https://preview.addons.mozilla.org/en-US/firefox/pages/collector_firstrun

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

<title>page_title_collector_firstrun :: Add-ons for Firefox</title>; that's in the outputted HTML.

Does this need an Apache restart, a merge out, or is the string missing its value?

Comment 15

[Wil Clouser [:clouserw]]

Still missing it's value

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Reopening for comment 14/comment 15.

Comment 17

[Wil Clouser [:clouserw]]

r26532

Comment 18

[Brian King [:kinger]]

Right now in the extension for firstrun we are pointing at:

https://%%AMO_HOST%%/en-US/collections

en-US is swapped out for current locale if necessary.

Please confirm that this needs to be changed to:

https://%%AMO_HOST%%/en-US/firefox/pages/collector_firstrun

Comment 19

[Justin Scott [:fligtar]]

Oh, I already changed that yesterday :)

Comment 20

[Brian King [:kinger]]

(In reply to comment #19)
> Oh, I already changed that yesterday :)

So with the new urls, it looks like you are using the users AMO locale setting rather than the Firefox locale. Is that what you want?

Comment 21

[Justin Scott [:fligtar]]

Yeah. If a locale doesn't exist on AMO it 404s instead of redirecting to something close. So it's best to just let AMO figure out which one it wants to serve.

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- pretty static page with the exception of bug 495355, which is scoped for 5.0.6.