no need for Math.abs when multiplying two numbers together.

RESOLVED FIXED

Status

Firefox for Android Graveyard
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: dougt, Assigned: dougt)

Tracking

Trunk
x86
Mac OS X

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 367091 [details] [diff] [review]
patch v.1

if ((Math.abs(dx*dx) + Math.abs(dy*dy)) > 100) {

should just be

if (dx*dx + dy*dy > 100) {
Attachment #367091 - Flags: review?(gavin.sharp)
(Assignee)

Updated

9 years ago
Attachment #367091 - Attachment is obsolete: true
Attachment #367091 - Flags: review?(gavin.sharp)
(Assignee)

Comment 1

9 years ago
Created attachment 367093 [details] [diff] [review]
patch v.1 (that works)
Assignee: nobody → doug.turner
Attachment #367093 - Flags: review?
(Assignee)

Updated

9 years ago
Attachment #367093 - Flags: review? → review?(gavin.sharp)
Comment on attachment 367093 [details] [diff] [review]
patch v.1 (that works)

MikeK was fixing this in bug 456621, but sure, go ahead and bitrot him!
Attachment #367093 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 3

9 years ago
i <3 MikeK

changeset:   430:50222518eb3b
tag:         tip
user:        Doug Turner <dougt@meer.net>
date:        Fri Mar 13 14:11:02 2009 -0700
summary:     483019.  no need for Math.abs when multiplying two numbers together. r=gavin
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.