Closed Bug 483064 Opened 17 years ago Closed 17 years ago

Setting "app.update.timer" to 60 and choosing "not now" for major update does not prompt user to update again 60 seconds later

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Version:
1.9.0 Branch
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: abillings, Unassigned)

Details

If a user goes to about:config and sets the value of app.update.timer to 60, they should be reprompted to download a major update after 60 seconds if they choose the "not now" button. On testing with Firefox 3.0.7 for the the 3.0.7 to 3.1 b3 Major Update, setting this value seems to have no effect. Choosing "not now" and waiting, the user is not prompted with the Major Update again. The user is also not prompted if they restart the browser after selecting "not now" and wait for a minute.
The timer used by app update and friends a) only fires every 10 minutes b) also has an interval that is read during startup so you need to restart for changes to take affect c) is rather more complicated than just changing the one pref.
Al, set the app.update.interval pref to something like 600 (miliseconds?), that should trigger the prompt without restarting if I remember correctly.
Nope, you do need to restart.
The testcases from the 2.x specifically say NOT to restart. Did this not require a restart in the past?
(In reply to comment #4) > The testcases from the 2.x specifically say NOT to restart. Did this not > require a restart in the past? No
The timers have always been set up at startup and require a restart to register the timers with the new interval entered in about:config. Resolving -> invalid and this is most likely caused by incorrect docs used to QA app update.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → INVALID
I did do a restart and still never got a prompt. So, specifically, which settings need to be changed to set the interval for the prompt to, for example, 60 seconds?
Al, please provide a link to the document you are using and I will review it as time permits.
I'm using a copied testcase from Firefox 2.x days that says to set app.update.timer to 60 and nothing else, wait to see what happens and, doing it all again, restarting and seeing what happens. Can you please confirm that I need to set both app.update.timer and app.update.interval together to get the same effect after restart, which is to get a prompt for the Major Update again after telling it "not now".
The prefs are app.update.timer -> set to a low number app.update.lastUpdateTime.background-update-timer -> clear app.update.interval -> set to a low number You do have to restart and since you haven't provided the (incorrect) doc so I could review it as I offered I'll let you take it from there.
The test in question is: https://litmus.mozilla.org/show_test.cgi?id=6733 I can confirm that the update dialog does not come up in Linux, after you follow the steps in the test case. However, there is an update notification on the lower right hand corner on my system. If you click on it, it pops up the MU offer dialog. It also happens in WinXP on the reference vms. I did not see this problem on a personal VM.
Reopening for further investigation.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
The alert notification that you saw was implemented for 3.0 and is expected. 12 hours later the update ui should be displayed.
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → INVALID
I didn't implement the current behavior but I do know what was implemented. From what you told me it appears that the test has been incorrect for a long time. Is there a litmus component for incorrect test steps where this bug can be moved to?
There may be. I just need someone to answer the actual question of what settings to change in order to override the prompt to be one minute (as an example). Can you tell me who can give QA this information, Rob?
To be clear, I can fix the testcase. I've been fixing issues as I find them. I need to know what to change the steps TO in the case in order to fix it though.
My bad, I didn't see that was added. Thanks.
to be clear that is for the alert notification. I'm not sure if the update ui will be displayed after the nagTimer interval since it was broken for a couple of the cases it handled which I fixed in that other bug. You *might* be able to get it to display by setting app.update.nagTimer.restart to a low number (e.g. 60)
You need to log in before you can comment on or make changes to this bug.