483089 - Weave Preferences button in Add-ons manager should be enabled

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Jono Xia]

Weave preferences button in the Add-ons manager is currently disabled.  It should be enabled and it should take you to Weave preferences.  This applies both to Firefox and Fennec.

Comment 1

[Dan Mills [:thunder]]

Should be easy enough.  -> 0.3, P2

Comment 2

[Ed Lee :Mardak]

https://developer.mozilla.org/en/Install_Manifests#optionsURL

It takes a url to open and it launches a dialog when clicked:
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/content/extensions.js#2587

Comment 3

[Jono Xia]

That will wok in Firefox, but in Fennec the preferences screen isn't a dialog box and can't be expressed as a chrome URL to open, so I'm not sure what we'll do there.

Comment 4

[Ed Lee :Mardak]

Well, even firefox it's not so happy as we re-use firefox's pref window, so we can't just point to a chrome uri..

Comment 5

[Dan Mills [:thunder]]

javascript uri? :^)

or how about a chrome uri that loads the right prefs ui and then closes itself? (yuck).

Adding mfinkle to cc list, he probably has some ideas here :)

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I wouldn't worry too much about this yet. Fennec will be re-working the Add-on Manager. The "Options" button will no longer just open a new window.

We are in the process of designing what will happen:
* No options from Add-ons Manager. Add-ons will overlay their options into the Fennec options list.
* Display options in-line (expand when you press the "Options" button)
* ...

Comment 7

[Dan Mills [:thunder]]

Okay, not worth considering this for 0.3 then. -> 0.4

Comment 8

[Igor Velkov]

Why not change prefwindow to simple dialog, for all cases?
All extensions do it.

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #8)
> Why not change prefwindow to simple dialog, for all cases?
> All extensions do it.

We don't really want the preferences to be in a dialog, prefwindow or window at all. Screens on mobile are much smaller than desktop. We are working on other ways to present preferences for mobile.

As to prefwindow versus dialog - both are popup windows. prefwindow is _designed_ to display preferences.

Comment 10

[Igor Velkov]

Looks like preferences button in the Add-ons manager not designed to display prefwindow, that is _designed_ to display preferences, huh? 
If all designed in consistency, then why did this bug still exist, not resolved with one string in install.rdf? Because one string in install.rdf can be used with normal dialog, but not with special designed for that prefwindow?

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #10)
> Looks like preferences button in the Add-ons manager not designed to display
> prefwindow, that is _designed_ to display preferences, huh?

No, it is in fact made to display a prefwindow
 
> If all designed in consistency, then why did this bug still exist, not resolved
> with one string in install.rdf? Because one string in install.rdf can be used
> with normal dialog, but not with special designed for that prefwindow?

This bug currently exists because Fennec (mobile) does not want any dialogs displayed for preferences and on Firefox (it seems) weave was putting preferences into Firefox's preference window, not making it's own with a prefwindow.

Comment 12

[Maaren]

Extra information:

The Calendar extension Lightning in Thunderbird is doing this correctly

Comment 13

[Mike Connor [:mconnor]]

It seems like they're just specifying the main prefwindow URL, does it actually have magic elsewhere to select the right window?

Comment 14

[Ed Lee :Mardak]

http://hg.mozilla.org/labs/weave/rev/25f76c6fd58c
Show the new pref pane (bug 521357) by having the options.xul file for Fennec (bug 523384) close iteself and open the real prefs window.