483098 - runreftest.py: add a '--log-file' option, as runtests.py.in has

Status: RESOLVED INACTIVE

(Testing :: Reftest, enhancement)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

As commented in bug 421611, it would be nice to have a --log-file option.  This would be very useful for Fennec, and I imagine others would find it useful.

Comment 1

[cmtalbert]

I think this would be useful on Windows as well because (from my testing at least) unless you have NO_EM_RESTART set, you won't get any output from reftest, which is a real awful setup.  Perhaps I should add that to the MDC article on reftests if it isn't already there...

Comment 2

[(not currently active) Ted Mielczarek]

Clint: it should work fine with "make reftest", as that explicitly runs the app twice, with -silent the first time to avoid the restart pain.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #0)
> it would be nice to have a --log-file option.

Do you actually need this option, or are the log files from bug 468913 and bug 484298 enough?

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for revisiting this.  We don't need a --log-file option for reftest/xpcshell anymore.  I have found these logging features to provide enough information.

Comment 5

[Serge Gautherie (:sgautherie)]

Let's morph the bug then,
as I think it would still be nice to replace '| tee ./$@.log' in
{
73  	RUN_REFTEST = rm -f ./$@.log && $(PYTHON) _tests/reftest/runreftest.py $(1) | tee ./$@.log
}
and when calling runreftest.py directly (as in bug 383136).

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why?  If somebody wants stdout to go to a file, they can; you don't need to add it as a feature to every program.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> Why?

Easy usage, synchronized behavior between tests harnesses, ...

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

one example of why this was originally consider is for windows ce where we don't have the luxury of stdout and file redirection.