The default bug view has changed. See this FAQ.

Fix Bugzilla JS/CSS for IE8

RESOLVED FIXED in Bugzilla 3.2

Status

()

Bugzilla
User Interface
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Max Kanat-Alexander, Assigned: Max Kanat-Alexander)

Tracking

unspecified
Bugzilla 3.2
Bug Flags:
approval +
approval3.4 +
blocking3.4 +
approval3.2 +
blocking3.2.4 +

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
We will probably have to adjust some things in Bugzilla to work right with IE8's standards mode. Probably just changing the conditional comment for the IE-fixes.css to to <!--[if lte IE 7]
(Assignee)

Comment 1

8 years ago
Also, apparently IE8 no longer supports the className DOM element attribute, and uses the standard "class" attribute instead. The solution here is to use YUI instead of setting className directly.
(Assignee)

Updated

8 years ago
Summary: Fix Bugzilla CSS for IE8 → Fix Bugzilla JS/CSS for IE8
(Assignee)

Comment 2

8 years ago
IE8 will roll out via Automatic Update starting the third week of April, meaning that shortly after that (probably within months) it will become the most popular browser on the Internet.

Right now I'm targeting fixing 3.2 and above. If it ends up being pretty simple to fix, I'll also update 3.0.
Flags: blocking3.4+
Flags: blocking3.2.4+
Target Milestone: --- → Bugzilla 3.2
(Assignee)

Comment 3

8 years ago
Created attachment 372165 [details] [diff] [review]
v1

Okay, actually, I don't see any significant problem with the JavaScript in IE8, so I just fixed the conditional comments to only fix the CSS for IE if we're in IE7 or lower.

Also, I didn't even see any serious breakage from the IE-fixes.css, so I don't think we need to backport this to 3.0.
Assignee: ui → mkanat
Status: NEW → ASSIGNED
Attachment #372165 - Flags: review?(bugzilla)

Comment 4

8 years ago
Byron?
Attachment #372165 - Flags: review?(bugzilla) → review+
Comment on attachment 372165 [details] [diff] [review]
v1

r=glob

Comment 6

8 years ago
Any reason why this bug is not approved for checkin?
Flags: approval?
Flags: approval3.4?
Flags: approval3.2?
(Assignee)

Updated

8 years ago
Flags: approval?
Flags: approval3.4?
Flags: approval3.4+
Flags: approval3.2?
Flags: approval3.2+
Flags: approval+
(Assignee)

Comment 7

8 years ago
tip:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.63; previous revision: 1.62
done

3.4:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.62.2.1; previous revision: 1.62
done

3.2:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.56.2.4; previous revision: 1.56.2.3
done
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.