483150 - Fix Bugzilla JS/CSS for IE8

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Max Kanat-Alexander]

We will probably have to adjust some things in Bugzilla to work right with IE8's standards mode. Probably just changing the conditional comment for the IE-fixes.css to to <!--[if lte IE 7]

Comment 1

[Max Kanat-Alexander]

Also, apparently IE8 no longer supports the className DOM element attribute, and uses the standard "class" attribute instead. The solution here is to use YUI instead of setting className directly.

Comment 2

[Max Kanat-Alexander]

IE8 will roll out via Automatic Update starting the third week of April, meaning that shortly after that (probably within months) it will become the most popular browser on the Internet.

Right now I'm targeting fixing 3.2 and above. If it ends up being pretty simple to fix, I'll also update 3.0.

Comment 3

[Max Kanat-Alexander]

Attachment: v1

Okay, actually, I don't see any significant problem with the JavaScript in IE8, so I just fixed the conditional comments to only fix the CSS for IE if we're in IE7 or lower.

Also, I didn't even see any serious breakage from the IE-fixes.css, so I don't think we need to backport this to 3.0.

Comment 4

[Frédéric Buclin]

Byron?

Comment 5

[:glob ✱]

Comment on attachment 372165 [details] [diff] [review]
v1

r=glob

Comment 6

[Frédéric Buclin]

Any reason why this bug is not approved for checkin?

Comment 7

[Max Kanat-Alexander]

tip:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.63; previous revision: 1.62
done

3.4:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.62.2.1; previous revision: 1.62
done

3.2:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.56.2.4; previous revision: 1.56.2.3
done