Closed Bug 483150 Opened 11 years ago Closed 11 years ago

Fix Bugzilla JS/CSS for IE8

Categories

(Bugzilla :: User Interface, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: mkanat, Assigned: mkanat)

Details

Attachments

(1 file)

We will probably have to adjust some things in Bugzilla to work right with IE8's standards mode. Probably just changing the conditional comment for the IE-fixes.css to to <!--[if lte IE 7]
Also, apparently IE8 no longer supports the className DOM element attribute, and uses the standard "class" attribute instead. The solution here is to use YUI instead of setting className directly.
Summary: Fix Bugzilla CSS for IE8 → Fix Bugzilla JS/CSS for IE8
IE8 will roll out via Automatic Update starting the third week of April, meaning that shortly after that (probably within months) it will become the most popular browser on the Internet.

Right now I'm targeting fixing 3.2 and above. If it ends up being pretty simple to fix, I'll also update 3.0.
Flags: blocking3.4+
Flags: blocking3.2.4+
Target Milestone: --- → Bugzilla 3.2
Attached patch v1Splinter Review
Okay, actually, I don't see any significant problem with the JavaScript in IE8, so I just fixed the conditional comments to only fix the CSS for IE if we're in IE7 or lower.

Also, I didn't even see any serious breakage from the IE-fixes.css, so I don't think we need to backport this to 3.0.
Assignee: ui → mkanat
Status: NEW → ASSIGNED
Attachment #372165 - Flags: review?(bugzilla)
Byron?
Attachment #372165 - Flags: review?(bugzilla) → review+
Any reason why this bug is not approved for checkin?
Flags: approval?
Flags: approval3.4?
Flags: approval3.2?
Flags: approval?
Flags: approval3.4?
Flags: approval3.4+
Flags: approval3.2?
Flags: approval3.2+
Flags: approval+
tip:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.63; previous revision: 1.62
done

3.4:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.62.2.1; previous revision: 1.62
done

3.2:

Checking in template/en/default/global/header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/header.html.tmpl,v  <--  header.html.tmpl
new revision: 1.56.2.4; previous revision: 1.56.2.3
done
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.