483152 - Stop giving the ability to get the native sqlite3_stmt pointer

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Shawn Wilsher :sdwilsh]

We don't need to do this, and with it, someone could mess up our internal state of mozStorageStatement.  This method should be culled from the idl (mozIStorageStatement).

Comment 1

[Shawn Wilsher :sdwilsh]

Eh, this won't be trivial to do, but will still be nice to do.

Comment 2

[Shawn Wilsher :sdwilsh]

Attachment: v1.0

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 367320 [details] [diff] [review]
v1.0

>diff --git a/storage/src/mozStorageStatementWrapper.h b/storage/src/mozStorageStatementWrapper.h
> protected:
>     sqlite3_stmt* NativeStatement() {
>-        return mStatement->GetNativeStatementPointer();
>+        return mStatement->nativeStatement();
>     }

Why does this NativeStatement escape your lower-casing wrath?  Planning to remove the function entirely later with a mod to mozStorageStatementWrapper:Initialize to use getColumnName so it is no longer used?

Comment 4

[Shawn Wilsher :sdwilsh]

(In reply to comment #3)
> Why does this NativeStatement escape your lower-casing wrath?  Planning to
> remove the function entirely later with a mod to
> mozStorageStatementWrapper:Initialize to use getColumnName so it is no longer
> used?
Yeah - I didn't want to create too much code churn all at once.

Comment 5

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/b48482c54995