See URL for the same code in automation.py. I made bsmedberg make this change there, but not in the Talos version. This means that currently the Talos crash logs have a zillion lines of spew from minidump_stackwalk that aren't necessary.
Assignee: nobody → anodelman
Priority: -- → P3
Created attachment 375278 [details] [diff] [review] cross platform 2> /dev/null Couldn't get this to work with the subprocess module, so switched to system. Since it is a blocking call either way, doesn't seem to matter.
Is http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#425 really insufficient in Talos?
Gah, I forgot to check in on automation.py. Well, both ways work. Guess that we could standardize with automation.py. Damned programming, there's always 6 or 7 ways of solving the same problem.
Created attachment 375282 [details] [diff] [review] [Checked in]cross platform 2> /dev/null (just like automation.py)
I totally linked that in the URL field when I filed this. :-P
Assignee: anodelman → nobody
Component: Release Engineering: Talos → Release Engineering
Patch still applies cleanly and is ready for landing.
Comment on attachment 375282 [details] [diff] [review] [Checked in]cross platform 2> /dev/null (just like automation.py) Checking in ttest.py; /cvsroot/mozilla/testing/performance/talos/ttest.py,v <-- ttest.py new revision: 1.28; previous revision: 1.27 done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.