talos needs to eat stderr when running minidump_stackwalk to process crashes

RESOLVED FIXED

Status

P3
normal
RESOLVED FIXED
10 years ago
5 years ago

People

(Reporter: ted, Assigned: anodelman)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

See URL for the same code in automation.py. I made bsmedberg make this change there, but not in the Talos version. This means that currently the Talos crash logs have a zillion lines of spew from minidump_stackwalk that aren't necessary.
Assignee: nobody → anodelman
Priority: -- → P3
(Assignee)

Comment 1

10 years ago
Created attachment 375278 [details] [diff] [review]
cross platform 2> /dev/null

Couldn't get this to work with the subprocess module, so switched to system.  Since it is a blocking call either way, doesn't seem to matter.
Attachment #375278 - Flags: review?(catlee)
(Assignee)

Comment 3

10 years ago
Gah, I forgot to check in on automation.py.  Well, both ways work.  Guess that we could standardize with automation.py.  Damned programming, there's always 6 or 7 ways of solving the same problem.
(Assignee)

Comment 4

10 years ago
Created attachment 375282 [details] [diff] [review]
[Checked in]cross platform 2> /dev/null (just like automation.py)
Attachment #375278 - Attachment is obsolete: true
Attachment #375282 - Flags: review?(catlee)
Attachment #375278 - Flags: review?(catlee)
I totally linked that in the URL field when I filed this. :-P
(Assignee)

Comment 6

10 years ago
Dammit.
Attachment #375282 - Flags: review?(catlee) → review+

Updated

10 years ago
Assignee: anodelman → nobody
Component: Release Engineering: Talos → Release Engineering

Updated

10 years ago
Assignee: nobody → anodelman
Assignee: anodelman → nobody
Assignee: nobody → anodelman
(Assignee)

Comment 7

10 years ago
Patch still applies cleanly and is ready for landing.
(Assignee)

Updated

10 years ago
Attachment #375282 - Attachment description: cross platform 2> /dev/null (just like automation.py) → [Checked in]cross platform 2> /dev/null (just like automation.py)
Attachment #375282 - Flags: checked‑in+ checked‑in+
(Assignee)

Comment 8

10 years ago
Comment on attachment 375282 [details] [diff] [review]
[Checked in]cross platform 2> /dev/null (just like automation.py)

Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.28; previous revision: 1.27
done
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.