483188 - talos needs to eat stderr when running minidump_stackwalk to process crashes

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P3)

Description

[(not currently active) Ted Mielczarek]

See URL for the same code in automation.py. I made bsmedberg make this change there, but not in the Talos version. This means that currently the Talos crash logs have a zillion lines of spew from minidump_stackwalk that aren't necessary.

Comment 1

[alice nodelman [:alice] [:anode]]

Attachment: cross platform 2> /dev/null

Couldn't get this to work with the subprocess module, so switched to system.  Since it is a blocking call either way, doesn't seem to matter.

Comment 2

[Benjamin Smedberg]

Is http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#425 really insufficient in Talos?

Comment 3

[alice nodelman [:alice] [:anode]]

Gah, I forgot to check in on automation.py.  Well, both ways work.  Guess that we could standardize with automation.py.  Damned programming, there's always 6 or 7 ways of solving the same problem.

Comment 4

[alice nodelman [:alice] [:anode]]

Attachment: [Checked in]cross platform 2> /dev/null (just like automation.py)

Comment 5

[(not currently active) Ted Mielczarek]

I totally linked that in the URL field when I filed this. :-P

Comment 6

[alice nodelman [:alice] [:anode]]

Dammit.

Comment 7

[alice nodelman [:alice] [:anode]]

Patch still applies cleanly and is ready for landing.

Comment 8

[alice nodelman [:alice] [:anode]]

Comment on attachment 375282 [details] [diff] [review]
[Checked in]cross platform 2> /dev/null (just like automation.py)

Checking in ttest.py;
/cvsroot/mozilla/testing/performance/talos/ttest.py,v  <--  ttest.py
new revision: 1.28; previous revision: 1.27
done