Closed Bug 483212 Opened 15 years ago Closed 15 years ago

Linux comm-central trunk nightly failing in build symbols step

Categories

(MailNews Core :: Build Config, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: florian)

References

Details

Attachments

(1 file)

This has been failing the last three days:

/usr/bin/gmake -C mozilla MAKE_SYM_STORE_PATH=.. SYM_STORE_SOURCE_DIRS="/buildbot/comm-central-trunk-linux-nightly/build/mozilla/extensions/inspector /buildbot/comm-central-trunk-linux-nightly/build/mozilla /buildbot/comm-central-trunk-linux-nightly/build" buildsymbols
gmake[1]: Entering directory `/buildbot/comm-central-trunk-linux-nightly/build/objdir-tb/mozilla'
echo building symbol store
building symbol store
rm -f -rf ./dist/crashreporter-symbols
/buildbot/comm-central-trunk-linux-nightly/build/objdir-tb/mozilla/config/nsinstall -D ./dist/crashreporter-symbols
/tools/python/bin/python /buildbot/comm-central-trunk-linux-nightly/build/mozilla/toolkit/crashreporter/tools/symbolstore.py \
	  -c --vcs-info                                          \
	  -s /buildbot/comm-central-trunk-linux-nightly/build/mozilla/extensions/inspector -s /buildbot/comm-central-trunk-linux-nightly/build/mozilla -s /buildbot/comm-central-trunk-linux-nightly/build               \
	  ./dist/host/bin/dump_syms                                                \
	  ./dist/crashreporter-symbols                                   \
	  .. >                                        \
	  ./dist/crashreporter-symbols/thunderbird-3.1a1pre-Linux-20090313030659-symbols.txt
objcopy: ../mozilla/js/src/shell/js.dbg: Invalid operation
gzip: dist/crashreporter-symbols/js/BF35F51CF60F15BB20A355CB42AB5A760/js.dbg.gz already exists; do you wish to overwrite (y or n)? 
command timed out: 1200 seconds without output, killing pid 11744
process killed by signal 9
program finished with exit code -1

Ted says this is likely a result of bug 420474, although the Firefox tinderboxes are fine, so he doesn't understand why we're seeing a problem here.

Its probably one of these two lines failing:

+        os.system("objcopy --only-keep-debug %s %s" % (file, file_dbg))
+        os.system("objcopy --add-gnu-debuglink=%s %s" % (file_dbg, file))
Attached patch possible fixSplinter Review
This error happens because some binary files are processed several times.
MAKE_SYM_STORE_PATH was set to ".." (that is, the whole objdir) in bug 450485 so that .pdb files could be found.

I think we need to replicate the logic used here: http://mxr.mozilla.org/comm-central/source/mozilla/Makefile.in#148 and only provide the dist/bin folder on linux.
Attachment #367680 - Flags: review?(kairo)
Comment on attachment 367680 [details] [diff] [review]
possible fix

I want gozer to look at this as well, as the change affects Thunderbird the same as SeaMonkey.
Attachment #367680 - Flags: review?(gozer)
Attachment #367680 - Flags: review?(gozer) → review+
Comment on attachment 367680 [details] [diff] [review]
possible fix

Looks good to me, and it's what mozilla-central does, dist/bin on linux.
Attachment #367680 - Flags: review?(kairo) → review+
Comment on attachment 367680 [details] [diff] [review]
possible fix

Ah, if Mozilla does it the same way, it surely makes sense, yes. Actually, this somehow looks to me like we probably should only hand over the MAKE_SYM_STORE_PATH override when we are on Windows, actually.
Keywords: checkin-needed
Assignee: gozer → florian
Component: Server Operations → Build Config
Product: Mozilla Messaging → MailNews Core
QA Contact: server-ops → build-config
Version: other → Trunk
Checked in: http://hg.mozilla.org/comm-central/rev/55d050eb1dca
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
Triggered an early linux trunk nightly, and its green. Uploaded symbols also look good.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.