bug 345339 introduced a violation, comiter's email is bouncing prbool complaints, so I'm filing this.
Graeme McCutcheon <email@example.com> introduced a new PRBool problem in changeset http://hg.mozilla.org/mozilla-central/rev/89840ed77dc8 of nsHTMLButtonElement.cpp.
Commit message: Bug 345339. Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store. Switch box objects to their own hashtable. r+sr=roc
601: In macro NS_ENSURE_ARG_POINTER
See Taras' blog for more info about prbool bugs
Er, yes. This is bad. On error, this will return a true value.
Graeme, want to fix?
Created attachment 367275 [details] [diff] [review]
Meh. I fail - that was a straight copy from Karthik's original patch, should have scrutinised it more closely.
Graeme, is this something we need to fix on 1.9.1 too?
> Graeme, is this something we need to fix on 1.9.1 too?
No. 345339 landed on trunk only.