bug 345339 introduced a violation, comiter's email is bouncing prbool complaints, so I'm filing this. Graeme McCutcheon <email@example.com> introduced a new PRBool problem in changeset http://hg.mozilla.org/mozilla-central/rev/89840ed77dc8 of nsHTMLButtonElement.cpp. Commit message: Bug 345339. Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store. Switch box objects to their own hashtable. r+sr=roc Error: /content/html/content/src/nsHTMLButtonElement.cpp: 601: In macro NS_ENSURE_ARG_POINTER http://mxr.mozilla.org/mozilla-central/source/content/html/content/src/nsHTMLButtonElement.cpp#601 See Taras' blog for more info about prbool bugs http://blog.mozilla.com/tglek/2008/11/07/enabling-prcheck-email-notifications/#respond
Er, yes. This is bad. On error, this will return a true value. Graeme, want to fix?
Created attachment 367275 [details] [diff] [review] Fix Meh. I fail - that was a straight copy from Karthik's original patch, should have scrutinised it more closely.
Pushed http://hg.mozilla.org/mozilla-central/rev/9a3b3f52eca3 Graeme, is this something we need to fix on 1.9.1 too?
> Graeme, is this something we need to fix on 1.9.1 too? No. 345339 landed on trunk only.