Last Comment Bug 483217 - prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp
: prbool violation in /content/html/content/src/nsHTMLButtonElement.cpp
: regression
Product: Core
Classification: Components
Component: Layout (show other bugs)
: unspecified
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Graeme McCutcheon [:graememcc]
: Jet Villegas (:jet)
Depends on:
Blocks: 345339
  Show dependency treegraph
Reported: 2009-03-13 08:01 PDT by (dormant account)
Modified: 2009-03-14 07:44 PDT (History)
7 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Fix (556 bytes, patch)
2009-03-13 12:49 PDT, Graeme McCutcheon [:graememcc]
bzbarsky: review+
bzbarsky: superreview+
Details | Diff | Splinter Review

Description (dormant account) 2009-03-13 08:01:55 PDT
bug 345339 introduced a violation, comiter's email is bouncing prbool complaints, so I'm filing this.

Graeme McCutcheon <> introduced a new PRBool problem in changeset of nsHTMLButtonElement.cpp.

Commit message: Bug 345339.  Make nsPresState not use a hashtable in favor of using less memory and only storing the things it really wants to store.  Switch box objects to their own hashtable.  r+sr=roc

Error: /content/html/content/src/nsHTMLButtonElement.cpp:

See Taras' blog for more info about prbool bugs
Comment 1 Boris Zbarsky [:bz] (still a bit busy) 2009-03-13 10:21:13 PDT
Er, yes.  This is bad.  On error, this will return a true value.

Graeme, want to fix?
Comment 2 Graeme McCutcheon [:graememcc] 2009-03-13 12:49:19 PDT
Created attachment 367275 [details] [diff] [review]

Meh. I fail - that was a straight copy from Karthik's original patch, should have scrutinised it more closely.
Comment 3 Boris Zbarsky [:bz] (still a bit busy) 2009-03-13 13:32:03 PDT

Graeme, is this something we need to fix on 1.9.1 too?
Comment 4 Graeme McCutcheon [:graememcc] 2009-03-13 13:36:42 PDT
> Graeme, is this something we need to fix on 1.9.1 too?

No. 345339 landed on trunk only.

Note You need to log in before you can comment on or make changes to this bug.