483229 - ReleaseUpdatesFactory should chmod 644 before uploading MAR files

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Comment 1

[[e-mail] (:bhearsum)]

Attachment: chmod files/dirs to 644/755 before rsync'ing back to stage

I gave this a good test in staging and it seemed to work correctly. A bustage fix from a previous patch snuck in here, too (run 'cvs co -d build mozilla/tools/patcher' in '.' instead of 'build').

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 368578 [details] [diff] [review]
chmod files/dirs to 644/755 before rsync'ing back to stage

Looks good, r+.

>+        self.addStep(ShellCommand,
>+         command=['find', marDir, '-type', 'd',
>+                  '-exec', 'chmod', '755', '{}', ';'],
>+         workdir='.',
>+         description=['chmod 755', 'partial mar dirs']
>+        )

Do you know if we enforce 755 on a $version-candidates/buildN/ dir before this point ? Appears that post_upload.py doesn't do anything like that.

Comment 3

[[e-mail] (:bhearsum)]

(In reply to comment #2)
> (From update of attachment 368578 [details] [diff] [review])
> Looks good, r+.
> 
> >+        self.addStep(ShellCommand,
> >+         command=['find', marDir, '-type', 'd',
> >+                  '-exec', 'chmod', '755', '{}', ';'],
> >+         workdir='.',
> >+         description=['chmod 755', 'partial mar dirs']
> >+        )
> 
> Do you know if we enforce 755 on a $version-candidates/buildN/ dir before this
> point ? Appears that post_upload.py doesn't do anything like that.

That...I'm not sure of. I did my testing by 'wget -r'ing a candidates dir and then setting permissions 644/755, then running Updates - which worked, obviously.

I guess if that's not the case in a full run Updates would end up fixing it (or bailing because of permissions problems). Probably the best thing to do here is file a follow up on fixing post_upload.py to set permissions for --release-to-candidates-dir. How does that sound to you?

Comment 4

[[e-mail] (:bhearsum)]

(In reply to comment #3)
> I guess if that's not the case in a full run Updates would end up fixing it (or
> bailing because of permissions problems). Probably the best thing to do here is
> file a follow up on fixing post_upload.py to set permissions for
> --release-to-candidates-dir. How does that sound to you?

I just filed bug 484972 about this.

Comment 5

[[e-mail] (:bhearsum)]

Comment on attachment 368578 [details] [diff] [review]
chmod files/dirs to 644/755 before rsync'ing back to stage

changeset:   228:335d8c29c29e

Comment 6

[[e-mail] (:bhearsum)]

I think we're all done here.