483329 - gloda indexer onAnnouncerGoingAway handler does not cleanup sufficiently

Status: RESOLVED FIXED

(MailNews Core :: Database, defect)

Description

[Andrew Sutherland [:asuth] (he/him)]

The database announcer listener's onAnnouncerGoingAway handler only calls _indexerLeaveFolder.  This used to be sufficient, but changes elsewhere mean that one of the generator functions on the callback handler loop can have forbidden state.  The price of forbidden state is high, for not only is it tantalizingly named, it also can translate into a crash.

We need a unit test that exercises this path.  A unit test involving compaction should probably also be added at the same time, especially if the two can be one.  I think bienvenu is doing some compaction work, so we might be able to reuse/copy that mechanism.

Comment 1

[David :Bienvenu]

http://mxr.mozilla.org/comm-central/source/mailnews/base/test/unit/test_folderCompact.js

this existing test does local folder compaction, which is what I think you care about (I've been working on some offline store compaction tests, but they're not interesting for this bug)

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Fixed in gloda correctness patch tracked on bug 465618.
trunk commit: http://hg.mozilla.org/comm-central/rev/413b2018349c

test_index_compaction.js exercises this.