483415 - Print Preview directional buttons are flipped for RTL locales

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

We need to use the RTL versions of the GTK stock icons for the print preview window directional toolbar buttons in RTL locales.

The attached patch does this.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 367398 [details] [diff] [review]
Patch (v1)

> .home-arrow {
>   list-style-image: url("moz-icon://stock/gtk-goto-first?size=menu");
> }

Shouldn't we use gtk-goto-first-ltr here?

>+[chromedir="rtl"].home-arrow {

.home-arrow[chromedir="rtl"], please? :)

We should probably get a bug filed on renaming left-arrow to back-arrow and right-arrow to forward-arrow, or at least adding these class names and leaving the old ones for backward compatibility.

Comment 2

[(no longer active)]

Attachment: Patch (v2)

(In reply to comment #1)
> (From update of attachment 367398 [details] [diff] [review])
> > .home-arrow {
> >   list-style-image: url("moz-icon://stock/gtk-goto-first?size=menu");
> > }
> 
> Shouldn't we use gtk-goto-first-ltr here?

Yeah, I guess being explicit is better here.

> >+[chromedir="rtl"].home-arrow {
> 
> .home-arrow[chromedir="rtl"], please? :)

Sure.  I was thinking in my head which of these is more readable, and I finally picked this style randomly!  :-)

> We should probably get a bug filed on renaming left-arrow to back-arrow and
> right-arrow to forward-arrow, or at least adding these class names and leaving
> the old ones for backward compatibility.

Filed bug 483419.

Comment 3

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/6e2308f99161

Comment 4

[(no longer active)]

Comment on attachment 367403 [details] [diff] [review]
Patch (v2)

Low-risk theme-only change which fixes an RTL theme problem for Linux.  Nice to have on 1.9.1.

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 367403 [details] [diff] [review]
Patch (v2)

a191=drivers

Comment 6

[(no longer active)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/dfd48c49dde4