48348 - CurrentPage.getSourceBytes(boolean) method returns null

Status: VERIFIED FIXED

(Core Graveyard :: Java APIs to WebShell, defect, P3)

Description

[Oleg Khokhlov]

It is because the native method "nativeGetSourceBytes" in CurrentPageImpl.cpp 
always returns null:

    jbyteArray result = nsnull;
    return result;

If it is not implemented yet, then method CurrentPage.getSourceBytes(boolean) in 
CurrentPageImpl.java must throw Unimplemented Exception.

Mozilla M16, Webclient source from August 07, 2000

Comment 1

[Gervase Markham [:gerv]]

Too true. Confirming.

Gerv

Comment 2

[edburns]

Reassigning to Ashu.

Comment 3

[geetha.vaidyanaathan]

Adding Status whiteboard keyword to track all Webclient existing bugs

Comment 4

[Ashu Kulkarni]

Attachment: cvs diff -u of files in this patch

Comment 5

[Ashu Kulkarni]

The fix utilizes the Java URL and URLConnection classes (java.net.*) to 
implement the getSource and getSourceBytes functions of the CurrentPage 
Interface. The implementation is pure Java and returns the correct type as 
defined in the Webclient API.

Ed, pls review and let me know if I have ra=edburns

_Ashu

Comment 6

[edburns]

Attachment: cvs diff -u of mod to EMWindow.java, setting the java pref for proxies.

Comment 7

[edburns]

This looks great.  

One thing before r=edburns.  Add the code in the previous attachment to your 
code before you check it in.

As a separate diff and checkin sequence, I want you to remove the existing view 
source java and native code.  After this is done, you can close this bug.

Ed

Comment 8

[Ashu Kulkarni]

Attachment: cvs diff -u (patch for java as well as native source files)

Comment 9

[Ashu Kulkarni]

Ed,

I have added your previous fix into EMWindow.java, updated my cvs codebase and 
done the diffs. I have checked in the fixes for the java files that you have 
approved. I have also checked in the fixes to the Native code that comments out 
the Native implementation of the GetSource Function. Since I didn't get a 
chance to get your review for this, I just commented out the code and checked 
it in. Once I get back, I will remove the commented code.

thanks
_Ashu

Comment 10

[edburns]

Looks good, but instead of commenting out the method, can you please remove it?

Comment 11

[edburns]

Oops, I see that you are already planning on doing what I requested.  Proceed.

Comment 12

[edburns]

Ashu, this fix was only half checked in. I have checked in the other half.

Comment 13

[Oleg Khokhlov]

I mark it as verified.