483548 - buildsymbols messes up Linux Z test results

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The Linux tinderbox is showing 15MB (or about the entire codesize) fluctuations in the Z number.  For a typical build when Z decreased by 15MB, here are the library files that are claimed to have gotten smaller:

libxpcom.so.dbg
nm2tsv.dbg
libunixprintplugin.so.dbg
libplds4.so.dbg
mozilla-xremote-client.dbg
nsinstall.dbg
libplc4.so.dbg
codesighs.dbg
libnullplugin.so.dbg
maptsvdifftool.dbg
etc, etc,
libxul.so.dbg,
etc

I assume that something is leaving files that it shouldn't in dist, right?

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Looks like fallout from bug 478876, which gives us stacks for talos.

Comment 2

[Phil Ringnalda (:philor)]

Graph server makes it look like it started midday 2009-03-11, which looks more like bug 420474. Ted's fault either way, but then that's no surprise ;)

Comment 3

[(not currently active) Ted Mielczarek]

Yeah, that bug makes us use objcopy --only-debug to split debug info out of binary files. We can probably fix the symbol store script to not leave those wherever they get counted by codesighs. Basically just change this copy to a move:
http://mxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/tools/symbolstore.py#658

Comment 4

[Boris Zbarsky [:bzbarsky]]

Another option would be to change autosummary.unix.bash to filter those files out; not sure which is a simpler/safer change.  Right now, autosummary uses the following command to find the files it wants:

  find $OBJROOT/dist/bin -not -type d

Can we do one or the other quickly, though?

Comment 5

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

Ted: Dont mind if you leave this bug here or not, but can you take this?

Comment 6

[(not currently active) Ted Mielczarek]

Attachment: move the .dbg files, don't copy them

This fixes the symbolstore script to not leave .dbg files in dist/bin. Works for me locally.

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

I don't think we're blowing away dist/bin at the top of each build, so we need to go round with a clobber or manual cleanup for this ?

Comment 8

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/132f022dcdd0

Comment 9

[(not currently active) Ted Mielczarek]

Nick: I think this should resolve itself (since they'll be overwritten and then moved), if it doesn't after a cycle you could do a:
find dist/bin -name "*.dbg" | xargs rm

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Verified that the script is moving *.dbg away, but unfortunately that happens after calculating Z for the current run. Went ahead and removed all the dbg's hanging around on the slaves (mozilla-central-linux dirs only).