Revert changes to region.properties on l10n-central and l10n-mozilla-1.9.1

RESOLVED FIXED

Status

Mozilla Localizations
vi / Vietnamese
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: stas, Unassigned)

Tracking

({fixed1.9.1})

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

9 years ago
I noticed two pushes to l10n-central and l10n-mozilla-1.9.1 that landed some changes to region.properties without a review. Please revert them:

http://hg.mozilla.org/l10n-central/vi/diff/a1ed9e0752bc/browser/chrome/browser-region/region.properties

We don't need this as we're not shipping Yahoo in Vietnamese builds.

http://hg.mozilla.org/l10n-central/vi/diff/59670faf0850/browser/chrome/browser-region/region.properties

Mibbit will be mass-added in bug 479030.

Please note: please don't land changes to region.properties or searchplugins/ without a review from the l10n-drivers team (even on the dev branch). These are sensitive pieces of localization that we watch over to make sure that the default settings are in line with the decisions taken with the localizers in the productization bugs.

Thanks.
My mistake. I sync our vi repository with our translations on Narro which in turn use the layouts of the en-US files. Next times, I'll remember to delete this file from the exported archive. (Btw, I'm still curious how sensitive that would affect, because uhm.. the Yahoo plugin is already not shipped in Vietnamese builds.)

I have reverted the changes:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/vi/rev/df72e8b54d60
http://hg.mozilla.org/l10n-central/vi/rev/1f54cf65d974
(Reporter)

Comment 2

9 years ago
Thanks Hùng! Marking as fixed. 

Regarding your question: as we don't ship Yahoo, there's no need to specify the second search engine in region.properties. Alpha ordering is enough in this case. The setting was obsolete, so we could safely remove it.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: fixed1.9.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.