Closed Bug 483591 Opened 11 years ago Closed 11 years ago

PRBool problem in nsIMEStateManager::IsActive

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

Product:
Core
Component:
DOM: UI Events & Focus Handling
Platform:
x86
Linux
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: taras.mozilla, Assigned: smaug)

References

Details

Attachments

(1 file)

patch
886 bytes, patch
bzbarsky
: review+
bzbarsky
: superreview+
Details | Diff | Splinter Review 
Olli Pettay <Olli.Pettay@helsinki.fi> introduced a new PRBool problem in changeset http://hg.mozilla.org/mozilla-central/rev/9088b4cee030 of nsIMEStateManager.cpp.

Commit message: Bug 478245 -  Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron

Error: /content/events/src/nsIMEStateManager.cpp:
 216: In macro NS_ENSURE_TRUE

http://mxr.mozilla.org/mozilla-central/source/content/events/src/nsIMEStateManager.cpp#216
Oops, sorry. Will fix.
Attached patch patch — — Splinter Review
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #368000 - Flags: superreview+
Attachment #368000 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/7dd5b9ceebc5
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.