Closed Bug 483633 Opened 15 years ago Closed 15 years ago

Mochitest test_threadErrors.html runs fine but needs to check/report success

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(
URL
)

Details

(Keywords: fixed1.9.1, Whiteboard: [fixed1.9.1b4])

Attachments

(2 files)

(Av1) Add |ok(true, ...);| [Checkin: Comment 8 & 10]
1.01 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review
(Bv1) Add |ok(true, ...);| to test_longThread.html too [Checkin: Comment 5 & 6]
841 bytes, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
(I noticed this on my Windows SeaMonkey/1.9.2 build...)

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237214422.1237222129.17732.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/16 07:40:22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237214422.1237217596.4967.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/16 07:40:22
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237215397.1237221564.16368.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/16 07:56:37

*** 29529 INFO Running /tests/dom/src/threads/test/test_threadErrors.html...
*** 29531 INFO Running /tests/dom/src/threads/test/test_threadTimeouts.html...
}
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/8d186b98ff31)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #367615 - Flags: review?(ctalbert.moz)
I'm not opposed to this at all, but why do we need it or care?
(In reply to comment #2)

It helps to identify successful tests as is (log, count, ...), like this one;
it helps to find out silently failing tests, like bug 451949 or bug 483391;
in bug 483407, I'm proposing to automatically detect the latter;
etc.
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.2a1pre) Gecko/20090318
Minefield/3.6a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/6f21cfb3a12d)

(I noticed this on my Windows SeaMonkey/1.9.2 build...)

{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366670.1237376580.14560.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/18 01:57:50
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237366174.1237371300.5105.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/18 01:49:34
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237364751.1237377089.15377.gz&fulltext=1
WINNT 5.2 mozilla-central unit test on 2009/03/18 01:25:51

*** 29500 INFO Running /tests/dom/src/threads/test/test_longThread.html...
*** 29502 INFO Running /tests/dom/src/threads/test/test_navigator.html...
}
Attachment #367997 - Flags: review?(jst)
Attachment #367997 - Flags: superreview+
Attachment #367997 - Flags: review?(jst)
Attachment #367997 - Flags: review+
Attachment #367615 - Flags: review?(ctalbert.moz) → review?(jst)
Attachment #367997 - Attachment description: (Bv1) Add |ok(true, ...);| to test_longThread.html too → (Bv1) Add |ok(true, ...);| to test_longThread.html too [Checkin: Comment 5]
Comment on attachment 367997 [details] [diff] [review]
(Bv1) Add |ok(true, ...);| to test_longThread.html too
[Checkin: Comment 5 & 6]


http://hg.mozilla.org/mozilla-central/rev/ac92990fb908
Attachment #367615 - Flags: superreview+
Attachment #367615 - Flags: review?(jst)
Attachment #367615 - Flags: review+
Comment on attachment 367997 [details] [diff] [review]
(Bv1) Add |ok(true, ...);| to test_longThread.html too
[Checkin: Comment 5 & 6]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/69a9deb49ab8
Attachment #367997 - Attachment description: (Bv1) Add |ok(true, ...);| to test_longThread.html too [Checkin: Comment 5] → (Bv1) Add |ok(true, ...);| to test_longThread.html too [Checkin: Comment 5 & 6]
(In reply to comment #5)
> (From update of attachment 367997 [details] [diff] [review])
> 
> http://hg.mozilla.org/mozilla-central/rev/ac92990fb908

V.Fixed, on this part:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237543426.1237550001.8047.gz&fulltext=1
Linux mozilla-central unit test on 2009/03/20 03:03:46

*** 29526 INFO Running /tests/dom/src/threads/test/test_longThread.html...
*** 29527 INFO TEST-PASS | /tests/dom/src/threads/test/test_longThread.html | All messages received from workers
}
Whiteboard: [fixed1.9.1b4: Bv1]
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 367615 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: Comment 8 & 10]


http://hg.mozilla.org/mozilla-central/rev/ecb3f8997a38
Attachment #367615 - Attachment description: (Av1) Add |ok(true, ...);| → (Av1) Add |ok(true, ...);| [Checkin: Comment 8]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
V.Fixed, on this part too:
{
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1237595933.1237599152.17944.gz&fulltext=1
OS X 10.5.2 mozilla-central unit test on 2009/03/20 17:38:53

*** 29570 INFO Running /tests/dom/src/threads/test/test_threadErrors.html...
*** 29571 INFO TEST-PASS | /tests/dom/src/threads/test/test_threadErrors.html | all errors correctly detected
}
Status: RESOLVED → VERIFIED
Comment on attachment 367615 [details] [diff] [review]
(Av1) Add |ok(true, ...);|
[Checkin: Comment 8 & 10]


http://hg.mozilla.org/releases/mozilla-1.9.1/rev/7532ef7c5210
Attachment #367615 - Attachment description: (Av1) Add |ok(true, ...);| [Checkin: Comment 8] → (Av1) Add |ok(true, ...);| [Checkin: Comment 8 & 10]
Keywords: fixed1.9.1
Whiteboard: [fixed1.9.1b4: Bv1] → [fixed1.9.1b4]
No longer blocks: 483407
Depends on: 483407
Component: DOM: Mozilla Extensions → DOM
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: