483661 - invalid utf8 mime assertions with invalid msg headers

Status: RESOLVED WORKSFORME

(MailNews Core :: MIME, defect)

Description

[David :Bienvenu]

Attachment: proposed fix

Occasionally I get junk messages which cause a bunch of assertions whenever the thread line of the message is displayed. This is painful when assertions bring up a dialog, which causes the line to be repainted, etc. I have a patch that stops the assertions.

The attached patch uses copyAsciiToUnicode if the string isn't utf8, which can happen when the mime2 decoding fails. Does this look reasonable?

Comment 1

[[e-mail]]

(In reply to comment #0)
> The attached patch uses copyAsciiToUnicode if the string isn't utf8, which can
> happen when the mime2 decoding fails. Does this look reasonable?
It looks to me that you've changed the block for when the decoding succeeds...

Comment 2

[David :Bienvenu]

(In reply to comment #1)
> (In reply to comment #0)
> > The attached patch uses copyAsciiToUnicode if the string isn't utf8, which can
> > happen when the mime2 decoding fails. Does this look reasonable?
> It looks to me that you've changed the block for when the decoding succeeds...

You're probably right - I had a couple versions of this patch in various trees, and this might be the bad one...

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

nsIMimeConverter::decodeMimeHeader is scriptable.  This should have a unit test.

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 367647 [details] [diff] [review]
proposed fix

Yeah, I think Neil's right - it looks like you've changed the wrong block. Canceling review whilst waiting for an updated patch.

+        !strcmp(header, decodedCstr) && !IsUTF8(nsDependentCString(decodedCstr)))

This should use MsgIsUTF8 now.

Comment 5

[David :Bienvenu]

I think some other patch has fixed this...