483751 - Gmail Compose - Send broke

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[L. Mohan Arun]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090316 Minefield/3.2a1pre

Latest Minefield build 20090316.

Gmail Compose Window. Have to hit on Send more than once or twice to get the message going. Doesnt happen in the first "Send" click. Works with IE7 and Opera normally

Reproducible: Always

Steps to Reproduce:
1. Gmail compose message
2. Hit send
3. Says working... but doesnt send. Click send again. Happens all the time. 
Actual Results:  
Send button not working in gmail compose

Expected Results:  
Work normally? 

Found yesterday, but I thought it is my network that is slow to load. But found that the same issue keeps occurring every time. And IE7 and Opera are handling Gmail compose fine

Comment 1

[Ria Klaassen (not reading all bugmail)]

Can you reproduce this in safe-mode? http://support.mozilla.com/en-US/kb/Safe+Mode
And if reproducible in safe-mode, do you get the same result with javascript.options.jit.content to false? http://kb.mozillazine.org/About:config

Comment 2

[L. Mohan Arun]

I started Minefield in safe mode, and the issue still occurs.

I then turned javascript options jit content to false. Then it starts working fine. (while still in safe mode)

Comment 3

[Ria Klaassen (not reading all bugmail)]

I can reproduce a bug, and that is the word "Loading" in the middle of the mailbox on top, even if the message is already sent. This is not due to JIT to true. It seems to break further actions, though.

Regression range appears to be:
 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=610fe3c5e234&tochange=54030de86b9c
and I verified this a couple of times.

Comment 4

[Peter van der Woude [:Peter6]]

same for deleting mails.

Comment 5

[L. Mohan Arun]

Gmail tasks is broke too. It works in IE7. I am using Minefield 20090317 build

Comment 6

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #5)
> Gmail tasks is broke too. It works in IE7. I am using Minefield 20090317 build

see also: https://bugzilla.mozilla.org/show_bug.cgi?id=483740#c1
since the range in comment 3 is narrowed down more than mine, i dupe the other bug to this one - the cause is the same.

@L. Mohan Arun: would have been nice if you had mentioned this bug# in the other report.

Comment 8

[L. Mohan Arun]

Ok I thought that bug is not getting noticed so I mentioned it here

Comment 9

[L. Mohan Arun]

This is not the only thing that has broken. Sometimes I have to click n click on a particular mail in the inbox to open up. It says Loading... and still loading... at the top. Works fine with opera and IE7.

Comment 10

[John]

I click on a label, then a threaded message and the threaded messages don't expand

Comment 11

[L. Mohan Arun]

yes, the Expand All is not working also, sometimes it works, sometimes does not. Need to click on that more than once, and reload the page, to get it to happen. Keeps saying :"Loading" but doesnt do anything after that

Comment 12

[Peter van der Woude [:Peter6]]

Ben Turner, 
could you please check which of your checkins caused this ?
This bug is preventing people to use builds older than those from the 20090313 because Gmail has become pretty much useless.

Comment 13

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I would expect bug 480185 is the most likely, can anyone verify?

Comment 15

[Tony Chung [:tchung]]

(In reply to comment #10)
> I click on a label, then a threaded message and the threaded messages don't
> expand

I confirm this as well.   This is only on trunk and not branch.  gmail is a major site, please block for this.

Comment 16

[RFLazaro]

(In reply to comment #13)
> I would expect bug 480185 is the most likely, can anyone verify?

Do you have a try-server build we can test?

Comment 17

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Ok, I've narrowed it down to mrbkap's attachment 366684 [details] [diff] [review] from bug 480185. Reverting that alone fixes this bug. Debugging gmail sucks.

Comment 18

[L. Mohan Arun]

Hi great, so gmail now works with Minefield latest build? Pls confirm so I can install Minefield nightly again. I had to uninstall MF and use the FF 3.1 b 3 because gmail was broke

Comment 19

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Clearly a blocker.

Comment 20

[WildcatRay]

(In reply to comment #18)
> Hi great, so gmail now works with Minefield latest build? Pls confirm so I can
> install Minefield nightly again. I had to uninstall MF and use the FF 3.1 b 3
> because gmail was broke
I don't think anything has been done yet with Trunk (Minefield) itself. There still needs to be a decision made as to what to do next. That may be backing out the item mentioned in Comment 17, redoing that patch, applying a new patch, or something else still to be determined.

Comment 21

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Shaver, Ray accidentally removed your blocking+. Please restore.

Comment 22

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

There were two problems here:
  * The wrong patch from bug 480185 landed and...
  * The API that the patch that was supposed to land used was mildly broken.

This patch takes care of both of those problems.

Comment 23

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/61440f2eb1f5

Comment 24

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090320 Minefield/3.6a1pre ID:20090320154408

VERIFIED/FIXED on Windows

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090322 Minefield/3.6a1pre ID:20090322035551 too.

Comment 26

[Tom Parker]

Verified with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090323 Minefield/3.6a1pre ID:20090323031543

Was previously able to consistently reproduce (reporter of bug 484253, a dupe of this), and now appears fixed on Linux.

Comment 27

[Johnny Stenback (:jst)]

Comment on attachment 368593 [details] [diff] [review]
Patch

Approving for 1.9.1 as this blocks mrbkap from merging his fix for bug 475864.

Comment 28

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9517f50933c5

Comment 29

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified on 1.9.1 with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b5pre) Gecko/20090511 Shiretoko/3.5b5pre ID:20090511031352