483778 - Error when trying to display removed file diff

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Stefan Plewako [:stef]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9.1b3) Gecko/20090305 Firefox/3.1b3
Build Identifier: 

Example:
 - changeset: http://hg.mozilla.org/comm-central/rev/2230/
 - removed file diff: http://hg.mozilla.org/comm-central/diff/2230/mail/locales/en-US/chrome/messenger/preferences/viewpasswords.dtd

Actual result: changeset page will display whole diff with info about removed files and single removed file diff page will return error ("An error occurred while processing your request").

Expected result: removed file diff page should display partial diff, just like changeset page is displaying whole.

Reproducible: Always

Comment 1

[(not currently active) Ted Mielczarek]

This is a hgweb bug. You could check and see if it's fixed in a newer version of Hg.

Comment 2

[Dirkjan Ochtman (:djc)]

Yeah, should be fixed in hg 1.1.

Comment 3

[Dirkjan Ochtman (:djc)]

Resolving as duplicate of 1.1 upgrade bug.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Depends on is more appropriate, I'd say...

Comment 5

[(not currently active) Ted Mielczarek]

Gavin: we'd rather not track upstream hg bugs directly in our bugzilla, which is why we duped it.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Ah, I see. I guess I'd still prefer INVALID over DUPE, since comment 2 didn't sound very certain that the upgrade would fix it, but that's just nitpicking.

Comment 7

[Stefan Plewako [:stef]]

http://hg.mozilla.org/mozilla-central/diff/30628/browser/locales/en-US/chrome/branding/brand.properties

Comment 8

[Dirkjan Ochtman (:djc)]

That's not the revision that file was removed in, so the error is correct. You're looking at the changes to that file in revision 30628, and the file wasn't there (nor was it there in the parent revision).

Resolving again.