Closed
Bug 483788
Opened 16 years ago
Closed 16 years ago
[FIX]NS_NewChannel leaks if protocol handler returns a channel and error
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
1.39 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
Arguably this is correct COM behavior (assume the out param is untouched on error), but in practice we don't do a good job of it.
Comment 1•16 years ago
|
||
outparams supposedly warns about such issues, but the false-positive count is still high enough not to be very useful.
![]() |
Assignee | |
Comment 2•16 years ago
|
||
Attachment #367767 -
Flags: review?(benjamin)
Comment 3•16 years ago
|
||
Comment on attachment 367767 [details] [diff] [review]
Proposed patch
Shouldn't you fix the protocol handler instead?
![]() |
Assignee | |
Comment 4•16 years ago
|
||
I did that too, of course; this is a belt-and-suspenders thing. I can't see any drawbacks to this change, but if you see one I'd love to hear about it.
Comment 5•16 years ago
|
||
Ah ok, this seems fine then.
Updated•16 years ago
|
Attachment #367767 -
Flags: review?(benjamin) → review+
![]() |
Assignee | |
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•