Closed Bug 483845 Opened 11 years ago Closed 11 years ago

Update Geolocation Strings to match latest madhava mockups

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dougt, Assigned: dougt)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 5 obsolete files)

http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#148

The current strings reflect a time when there was 3 states (exact, fuzzed, no).  During recent discussions, we want to change this text such that it reflects the binary decision the user has (yes, or no).
Attached patch browser patch v.1 (obsolete) — Splinter Review
Attachment #368072 - Flags: review?
Attachment #368072 - Flags: review? → review?(mconnor)
Attached patch patch v.2 (obsolete) — Splinter Review
changes all of the property names.
Attachment #368072 - Attachment is obsolete: true
Attachment #368072 - Flags: review?(mconnor)
Attached patch patch v.3 (obsolete) — Splinter Review
dropping l10n comment.
Attachment #368090 - Attachment is obsolete: true
Attachment #368091 - Flags: review?(mconnor)
Attached patch fennec string changes (obsolete) — Splinter Review
fennec has similar usages.
Attachment #368102 - Flags: review?(mark.finkle)
Comment on attachment 368091 [details] [diff] [review]
patch v.3

>+geolocation.tellThem=Tell them
>+geolocation.tellThemKey=E

use lower-case e here, matching case is faster (looks for the first exact match, then inverts, AIUI)

>+geolocation.learnMore=Learn more.
>+geolocation.thisTime=This time
>+geolocation.always=Always

What are these strings for?
Attached patch patch v.4Splinter Review
Attachment #368091 - Attachment is obsolete: true
Attachment #368102 - Attachment is obsolete: true
Attachment #368126 - Flags: review?(mconnor)
Attachment #368102 - Flags: review?(mark.finkle)
Attachment #368091 - Flags: review?(mconnor)
Blocks: 484074
Attachment #368126 - Flags: ui-review+
Attachment #368126 - Flags: review?(mconnor)
Attachment #368126 - Flags: review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Why not use T and D for the access keys?
@gavin is there a list of available keyboard shortcuts?
Attached patch update the access-keys (obsolete) — Splinter Review
Attachment #368155 - Flags: ui-review?(mconnor)
Attachment #368155 - Flags: review?(mconnor)
Comment on attachment 368126 [details] [diff] [review]
patch v.4

a191=beltzner
Attachment #368126 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 368155 [details] [diff] [review]
update the access-keys

worked fine on window 32, and mac.
Comment on attachment 368155 [details] [diff] [review]
update the access-keys

i am spawning off a new bug to address the keyboard shortcut keys:

https://bugzilla.mozilla.org/show_bug.cgi?id=484124
Attachment #368155 - Attachment is obsolete: true
Attachment #368155 - Flags: ui-review?(mconnor)
Attachment #368155 - Flags: review?(mconnor)
You need to log in before you can comment on or make changes to this bug.