Closed
Bug 483845
Opened 15 years ago
Closed 15 years ago
Update Geolocation Strings to match latest madhava mockups
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: dougt, Assigned: dougt)
References
Details
(Keywords: fixed1.9.1)
Attachments
(2 files, 5 obsolete files)
|
3.57 KB,
patch
|
mconnor
:
review+
mconnor
:
ui-review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
|
97.61 KB,
image/png
|
Details |
updated wireframes
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#148 The current strings reflect a time when there was 3 states (exact, fuzzed, no). During recent discussions, we want to change this text such that it reflects the binary decision the user has (yes, or no).
|
Assignee | |
Comment 1•15 years ago
|
||
Attachment #368072 -
Flags: review?
|
|
Assignee | |
Updated•15 years ago
|
Attachment #368072 -
Flags: review? → review?(mconnor)
|
|
Assignee | |
Comment 2•15 years ago
|
||
changes all of the property names.
Attachment #368072 -
Attachment is obsolete: true
Attachment #368072 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 3•15 years ago
|
||
dropping l10n comment.
Attachment #368090 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•15 years ago
|
Attachment #368091 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 4•15 years ago
|
||
fennec has similar usages.
Attachment #368102 -
Flags: review?(mark.finkle)
|
||
Comment 5•15 years ago
|
||
Comment on attachment 368091 [details] [diff] [review] patch v.3 >+geolocation.tellThem=Tell them >+geolocation.tellThemKey=E use lower-case e here, matching case is faster (looks for the first exact match, then inverts, AIUI) >+geolocation.learnMore=Learn more. >+geolocation.thisTime=This time >+geolocation.always=Always What are these strings for?
|
|
Assignee | |
Comment 6•15 years ago
|
||
Attachment #368091 -
Attachment is obsolete: true
Attachment #368102 -
Attachment is obsolete: true
Attachment #368126 -
Flags: review?(mconnor)
Attachment #368102 -
Flags: review?(mark.finkle)
Attachment #368091 -
Flags: review?(mconnor)
|
|
||
Updated•15 years ago
|
Attachment #368126 -
Flags: ui-review+
Attachment #368126 -
Flags: review?(mconnor)
Attachment #368126 -
Flags: review+
|
|
Assignee | |
Comment 7•15 years ago
|
||
Comment on attachment 368126 [details] [diff] [review] patch v.4 http://hg.mozilla.org/mozilla-central/rev/c0eea14622a6
Attachment #368126 -
Flags: approval1.9.1?
|
|
Assignee | |
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Comment 8•15 years ago
|
||
Why not use T and D for the access keys?
|
|
Assignee | |
Comment 9•15 years ago
|
||
@gavin is there a list of available keyboard shortcuts?
|
|
Assignee | |
Comment 10•15 years ago
|
||
Attachment #368155 -
Flags: ui-review?(mconnor)
Attachment #368155 -
Flags: review?(mconnor)
|
||
Comment 11•15 years ago
|
||
Comment on attachment 368126 [details] [diff] [review] patch v.4 a191=beltzner
Attachment #368126 -
Flags: approval1.9.1? → approval1.9.1+
|
|
Assignee | |
Comment 12•15 years ago
|
||
Comment on attachment 368155 [details] [diff] [review] update the access-keys worked fine on window 32, and mac.
|
|
Assignee | |
Comment 13•15 years ago
|
||
Comment on attachment 368155 [details] [diff] [review] update the access-keys i am spawning off a new bug to address the keyboard shortcut keys: https://bugzilla.mozilla.org/show_bug.cgi?id=484124
Attachment #368155 -
Attachment is obsolete: true
Attachment #368155 -
Flags: ui-review?(mconnor)
Attachment #368155 -
Flags: review?(mconnor)
|
|
Assignee | |
Comment 14•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/3bd7a93bfbb4
Keywords: fixed1.9.1
|
||
Comment 15•15 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•