Closed Bug 483899 Opened 13 years ago Closed 13 years ago

Fix warnings in nsOperaProfileMigrator

Categories

(Firefox :: Migration, defect)

Product:
Firefox
Component:
Migration
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

Attachments

(1 file)

Fix
8.08 KB, patch
jst
: review+
jst
: superreview+
Details | Diff | Splinter Review 
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: missing braces around initializer for ‘nsOperaProfileMigrator::PrefTransform::<anonymous union>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:337: warning: deprecated conversion from string constant to ‘char*’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp: In member function ‘nsresult nsOperaCookieMigrator::AddCookieOverride(nsIPermissionManager*)’:
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:886: warning: enumeral mismatch in conditional expression: ‘nsIPermissionManager::<anonymous enum>’ vs ‘nsIPermissionManager::<anonymous enum>’
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp: In member function ‘nsresult nsOperaProfileMigrator::CopySmartKeywords(nsINavBookmarksService*, nsIStringBundle*, PRInt64)’:
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:1170: warning: comparison between signed and unsigned integer expressions
/home/mrbkap/work/js/mozilla/browser/components/migration/src/nsOperaProfileMigrator.cpp:1182: warning: comparison between signed and unsigned integer expressions
Attached patch Fix — — Splinter Review 
There was some implicit dependency on signed->unsigned conversion that I made explicit (to quiet a warning and to better document what was going on).
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #367913 - Flags: superreview?(jst)
Attachment #367913 - Flags: review?(jst)
Attachment #367913 - Flags: superreview?(jst)
Attachment #367913 - Flags: superreview+
Attachment #367913 - Flags: review?(jst)
Attachment #367913 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/5c68715b5231
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.