Closed
Bug 483920
Opened 16 years ago
Closed 16 years ago
TM: massive slowdown in string-unpack-code in TM tip
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gal, Assigned: dmandelin)
Details
(Keywords: fixed1.9.1, Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
1.02 KB,
patch
|
gal
:
review+
|
Details | Diff | Splinter Review |
It takes 30s or so to complete.
whale:src gal$ TRACEMONKEY=stats ./Darwin_DBG.OBJ/js -j t/string-unpack-code.js
recorder: started(8), aborted(0), completed(50), different header(0), trees trashed(0), slot promoted(0), unstable loop variable(0), breaks(0), returns(0), unstableInnerCalls(0)
monitor: triggered(100), exits(100), type mismatch(0), global mismatch(0)
|
Reporter | |
Comment 1•16 years ago
|
||
I think the following patch caused this:
http://hg.mozilla.org/tracemonkey/rev/c923f9ce63ee
|
|
Assignee | |
Comment 2•16 years ago
|
||
Of course, it always helps to actually save the entire regexp source if you're going to compare using the whole thing.
|
|
Reporter | |
Comment 3•16 years ago
|
||
Comment on attachment 367943 [details] [diff] [review]
Patch
re_length - 1 looks wrong to me.
|
|
Reporter | |
Comment 4•16 years ago
|
||
Comment on attachment 367943 [details] [diff] [review]
Patch
no wait its correct. we have [1] already in the struct since msvc doesn't understand [0]. landing for dmandelin.
Attachment #367943 -
Flags: review?(gal) → review+
|
|
Reporter | |
Comment 5•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/9e1d2f3f8278
I wonder whether this bug has anything to do with the slowdown we sometimes observed in regexp-dna in the browser?
Whiteboard: fixed-in-tracemonkey
|
||
Comment 6•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Comment 7•16 years ago
|
||
Flags: blocking1.9.1+
Keywords: fixed1.9.1
You need to log in
before you can comment on or make changes to this bug.
Description
•