bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

gcc 4.4 warnings about "may be undefined" operations

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: wolfiR, Assigned: Waldo)

Tracking

({fixed1.9.1})

1.9.1 Branch
fixed1.9.1
Points:
---
Bug Flags:
wanted1.9.1 +
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
jstracer.cpp: In function 'bool isPromoteInt(nanojit::LIns*)':
jstracer.cpp:624: warning: operation on 'd' may be undefined
jstracer.cpp: In function 'bool isPromoteUint(nanojit::LIns*)':
jstracer.cpp:631: warning: operation on 'd' may be undefined
(Reporter)

Comment 1

10 years ago
On a sidenote I'm a bit confused as jstracer.cpp is not compiled on x86-64 Linux apparently
Hardware: All → x86
(Assignee)

Comment 2

10 years ago
Hm, this is pretty bad actually -- we're relying on spec-undefined left-then-right order of evaluation for ==.  Presumably every compiler we've tested against is doing left-then-right, else we'd have had crashes in tests, but this is going to bite us eventually if we keep relying on it.
Assignee: general → jwalden+bmo
Status: NEW → ASSIGNED
Flags: wanted1.9.1?
OS: Linux → All
Hardware: x86 → All
(Assignee)

Comment 3

10 years ago
Created attachment 368348 [details] [diff] [review]
Patch
Attachment #368348 - Flags: review?(gal)
(Assignee)

Comment 4

10 years ago
jstracer.cpp isn't compiled on x86-64 because JIT isn't going to be supported in 64-bit builds for a little while; with no official 64-bit release and fairly few people running 64-bit OSes it didn't make sense to put special effort into 64-bit right now.

Updated

10 years ago
Attachment #368348 - Flags: review?(gal) → review+
(Assignee)

Comment 5

10 years ago
http://hg.mozilla.org/tracemonkey/rev/2b3812472561
Whiteboard: fixed-in-tracemonkey

Comment 6

10 years ago
http://hg.mozilla.org/mozilla-central/rev/2b3812472561
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

10 years ago
Flags: in-testsuite-

Updated

9 years ago
Flags: wanted1.9.1? → wanted1.9.1+
You need to log in before you can comment on or make changes to this bug.