Closed
Bug 484010
Opened 15 years ago
Closed 15 years ago
jslock.h conflicts with AIX system header priv.h
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: andrew, Assigned: andrew)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
2.22 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7 Build Identifier: mozilla-central "/usr/include/sys/priv.h", line 69.9: 1540-0848 (S) The macro name "SET_OBJ_INFO" is already defined with a different definition. "jslock.h", line 296.9: 1540-0425 (I) "SET_OBJ_INFO" is defined on line 296 of "jslock.h". Please make #defines in jslock.h more unique by prefixing with JS_ or something similar to avoid conflict with AIX system headers. Reproducible: Always
Assignee | ||
Comment 1•15 years ago
|
||
Updated•15 years ago
|
Attachment #368033 -
Flags: review?(mrbkap)
Updated•15 years ago
|
Attachment #368033 -
Flags: review?(mrbkap) → review+
Comment 2•15 years ago
|
||
Either request SR if necessary or set checkin-needed keyword.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Updated•15 years ago
|
Assignee: general → andrew
Comment 3•15 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=484010
Whiteboard: fixed-in-tracemonkey
Assignee | ||
Updated•15 years ago
|
Keywords: checkin-needed
Comment 4•15 years ago
|
||
Comment on attachment 368033 [details] [diff] [review] add JS_ prefix to #defines >diff -r 6d71ec255150 js/src/jslock.h >--- a/js/src/jslock.h Wed Mar 18 15:59:57 2009 +0100 >+++ b/js/src/jslock.h Wed Mar 18 12:19:04 2009 -0400 >@@ -136,10 +136,10 @@ > > #ifdef JS_DEBUG_TITLE_LOCKS > >-#define SET_OBJ_INFO(obj_, file_, line_) \ >- SET_SCOPE_INFO(OBJ_SCOPE(obj_), file_, line_) >+#define JS_SET_OBJ_INFO(obj_, file_, line_) \ >+ JS_SET_SCOPE_INFO(OBJ_SCOPE(obj_), file_, line_) > >-#define SET_SCOPE_INFO(scope_, file_, line_) \ >+#define JS_SET_SCOPE_INFO(scope_, file_, line_) \ The backslashes should remain in column 79. /be
Comment 5•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/3ec5c672f872
Updated•15 years ago
|
Flags: in-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•