484033 - extend nsICrashReporter to allow crashreporter to be used without going through XRE_Main

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

It would be nice to be able to get stack traces from xpcshell tests when they crash (bug 483062). xpcshell can't currently use the crashreporter code because the only way to initialize it is either to startup through XRE_Main, or to call it from C++. I've added a few things to nsICrashReporter to make it usable from xpcshell.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: extend nsICrashReporter

Needs a pass through the try server, but works fine on my mac. This extends nsICrashReporter, adding the following properties:
.enabled
.serverURL
.minidumpPath

It also adds an xpcshell test (yay!) I'll probably build on this and add a test that actually forces a crash and checks the dump later.

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 368074 [details] [diff] [review]
extend nsICrashReporter

Passes the try server.

Comment 3

[Benjamin Smedberg]

Comment on attachment 368074 [details] [diff] [review]
extend nsICrashReporter

Do you want to sanity-check the URL at all, to force it to be HTTP for example?

Comment 4

[(not currently active) Ted Mielczarek]

Yeah, I'll fix that. I also realized that this test might fail on --disable-libxul builds that have crash reporting enabled, since they won't be able to get the crashreporter service, so I'll tweak the test to accomodate.

Comment 5

[(not currently active) Ted Mielczarek]

Pushed to m-c:
http://hg.mozilla.org/mozilla-central/rev/8e464707cf5b

Comment 6

[(not currently active) Ted Mielczarek]

I'd like to take this on 1.9.1 to enable bug 483062, but I guess I'll have to move the interface changes to a new branch-only interface. Should be feasible, although we should sort out bug 488596 first.