484059 - Not localized elements in the developer tools

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Leszek Zyczkowski]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.0.8pre) Gecko/2009022706 GranParadiso/3.0.8pre
Build Identifier: 

In the new developer tools are not localized elements:

Upload File – button
(%1$s %2$s file) – string displayed in the Developer Dashboard next to Versions and Files

Reproducible: Always

Comment 1

[Vlado Valastiak [:wladow]]

Another one:
Change Status page - Active Status - string 'Available Actions' (however localized in Add-on Status section above on the same page)

Comment 2

[Jeff Balogh (:jbalogh)]

Thanks for the reports–hopefully there won't be many more that slipped through the cracks.

I have fixes for Upload File and Available Actions.

@Leszek Can you give me a screenshot for (%1$s %2$s file)?  I can't find that one.

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: (%1$s %2$s file)

(In reply to comment #2)
Main Developer Dashboard page - https://preview.addons.mozilla.org/en-US/developers/dashboard

Comment 5

[Jeff Balogh (:jbalogh)]

From 484061: <a %s>List of supported applications</a> in versions_edit

Another: "status page" link in uploader.thtml

Comment 6

[Vlado Valastiak [:wladow]]

Another: Versions and Files - click on particular version - Platform combo - 'ALL' item

Comment 7

[Jeff Balogh (:jbalogh)]

@Vlado: The ALL text can be fixed with the localizer tools: https://addons.mozilla.org/localizers/platforms

Comment 8

[Jeff Balogh (:jbalogh)]

Attachment: fixing L10n strings in devcp that were overlooked

Comment 9

[Jesper Kristensen]

(In reply to comment #7)
> @Vlado: The ALL text can be fixed with the localizer tools:
> https://addons.mozilla.org/localizers/platforms

No. Platforms cannot be localized (Access Denied) and besides that, last time I checked, ALL is a keyword which is compared to hardcoded strings in lots of places in the code (that is why it is in uppercase to remind you that it should not be displayed in the UI)

Comment 10

[Fred Wenzel [:wenzel]]

Comment on attachment 369328 [details] [diff] [review]
fixing L10n strings in devcp that were overlooked

Looks good, only question: "describe_version_status" is not really following the same style as the other strings which start with "devcp_", right?

Comment 11

[Jeff Balogh (:jbalogh)]

r23876, with devcp_ fix