Closed
Bug 484063
Opened 16 years ago
Closed 16 years ago
safeb request format wrong for tables with no existing data
Categories
(Toolkit :: Safe Browsing, defect, P2)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 3.6a1
People
(Reporter: dcamp, Assigned: dcamp)
Details
(Keywords: fixed1.9.0.11, fixed1.9.1, Whiteboard: [fixed1.9.1b4])
Attachments
(1 file)
|
953 bytes,
patch
|
tony
:
review+
samuel.sidler+old
:
approval1.9.0.11+
|
Details | Diff | Splinter Review |
We're sending goog-malware-shavar;:mac, we should be sending goog-malware-shavar;mac.
Attachment #368105 -
Flags: review?(tony)
|
||
Comment 1•16 years ago
|
||
Comment on attachment 368105 [details] [diff] [review]
fix
[Checkin: Comment 6 & 7]
Is it possible to have a test for this (or maybe it's already covered and a test needs to be updated)?
Attachment #368105 -
Flags: review?(tony) → review+
|
||
Comment 2•16 years ago
|
||
This looks like a problem in the FF3.0.x code as well.
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.9?
Flags: blocking1.9.0.8?
Flags: blocking-firefox3.5?
|
||
Updated•16 years ago
|
Flags: blocking-firefox3.5? → blocking-firefox3.5+
Priority: -- → P2
|
|
||
Updated•16 years ago
|
Assignee: nobody → dcamp
|
|
||
Updated•16 years ago
|
Whiteboard: [needs landing]
|
|
||
Updated•16 years ago
|
Flags: blocking1.9.0.8?
|
|
||
Comment 3•16 years ago
|
||
Not blocking 190, but we'll approve the patch if you want to get it in.
Flags: blocking1.9.0.10?
|
||
Comment 4•16 years ago
|
||
adding in-testsuite? per comment #1.
Flags: in-testsuite?
OS: Mac OS X → All
Hardware: x86 → All
|
Assignee | |
Comment 5•16 years ago
|
||
We don't currently have a good automated framework for testing the request format. While we should probably get one of those eventually, I wouldn't block this (really simple) change on it.
|
||
Updated•16 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [needs landing] → [needs 1.9.1 landing]
Target Milestone: --- → Firefox 3.6a1
|
||
Comment 7•16 years ago
|
||
Comment on attachment 368105 [details] [diff] [review]
fix
[Checkin: Comment 6 & 7]
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/0f024e162d47
Attachment #368105 -
Attachment description: fix → fix
[Checkin: Comment 6 & 7]
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs 1.9.1 landing] → [needs cvs/1.9.0 landing: needs approval] [fixed1.9.1b4]
Version: unspecified → Trunk
|
|
||
Updated•16 years ago
|
Attachment #368105 -
Flags: approval1.9.0.10?
|
||
Comment 8•16 years ago
|
||
Comment on attachment 368105 [details] [diff] [review]
fix
[Checkin: Comment 6 & 7]
Yeah, ok. Approved for 1.9.0.10. a=ss
Attachment #368105 -
Flags: approval1.9.0.10? → approval1.9.0.10+
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [needs cvs/1.9.0 landing: needs approval] [fixed1.9.1b4] → [needs cvs/1.9.0 landing] [fixed1.9.1b4]
|
||
Comment 9•16 years ago
|
||
Checking in toolkit/components/url-classifier/content/listmanager.js;
new revision: 1.32; previous revision: 1.31
Keywords: checkin-needed → fixed1.9.0.10
Whiteboard: [needs cvs/1.9.0 landing] [fixed1.9.1b4] → [fixed1.9.1b4]
|
||
Comment 10•16 years ago
|
||
Is the only way to verify this to sniff the connection over the wire? How do we trigger the safeb request on demand?
|
|
||
Comment 11•16 years ago
|
||
Tony: Can you verify that 1.9.0 nightly builds use the right format on your end?
|
|
||
Comment 12•16 years ago
|
||
Sorry for the delay. Looking at the server logs, we aren't seeing enough traffic from the nightlies to say for sure. Can you test on the client side by sniffing the http requests?
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•