484068 - Default button shouldn't have an accesskey

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[Vlado Valastiak [:wladow]]

Default buttons in Application Update Wizard shouldn't use accesskeys as they are accessible via Enter key. Per bug 465607 comment 3 OS UI guidelines recommend not to use accesskeys for default buttons.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: native wizard ui with accesskey on a default button

I don't believe this is valid for Windows.

Comment 2

[Vlado Valastiak [:wladow]]

We are inconsistent here, as 'Cancel' button doesn't use an accesskey, other buttons do. And at least 'OK' button with accesskey set looks strange.

Based on bug 465607 comment 3 cc'ing Neil to see what's his opinion here.

Comment 3

[Vlado Valastiak [:wladow]]

Attachment: several screens of update wizard dialogs

Comment 4

[Neil Deakin]

Actually, the OS guidelines are a bit inconsistent. On Windows, at least, OK and Cancel should never have accesskeys. The guidelines at http://msdn.microsoft.com/en-us/library/bb545462.aspx state that other labels should do, but I'm pretty sure another version said not to.

Anyway, I think that Next and Previous should have access keys but Finish should probably not. For a more authoritative answer you might ask a ui person like Alex Faaborg.

Comment 5

[Robert Strong (they/them - no direct email)]

This UI is displayed very seldom and we no longer have an ok button in this ui so we're not going to change this. The better route would be to get rid of this ui altogether and provide an in product widget instead of a window to provide the same functionality.