484094 - Dynamic Containers should use nsINavBookmarksObserver::OnBeforeItemRemoved

Status: RESOLVED WONTFIX

(Toolkit :: Places, defect)

Description

[Shawn Wilsher :sdwilsh]

Dynamic Containers should use nsINavBookmarksObserver::OnBeforeItemRemoved instead of it's own special casing code.

Comment 1

[Marco Bonardo [:mak]]

i think i already removed that completely in the redesign, the service that populates then should be a bookmarks observer by itself if needed.

Comment 2

[Marcia Knous [:marcia]]

I am getting this error in the Error console while testing Beta 1 - Error: [Exception... "'JavaScript component does not have a method named: "onBeforeItemRemoved"' when calling method: [nsINavBookmarkObserver::onBeforeItemRemoved]"  nsresult: "0x80570030 (NS_ERROR_XPC_JSOBJECT_HAS_NO_FUNCTION_NAMED)"  location: "JS frame :: file:///Users/mozilla/Desktop/BETA/Firefox.app/Contents/MacOS/components/nsLivemarkService.js :: LS_deleteLivemarkChildren :: line 582"  data: no]
Source File: file:///Users/mozilla/Desktop/BETA/Firefox.app/Contents/MacOS/components/nsLivemarkService.js
Line: 582.

Is this related?

Comment 3

[Marco Bonardo [:mak]]

no, livemarks are not yet dynamic containers, that's a separate issue.

Comment 4

[Marco Bonardo [:mak]]

no more dynamic containers fwiw