Migration wizard starts with very small width/height.

RESOLVED FIXED in 1.0b1

Status

defect
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: eagle.lu, Assigned: eagle.lu)

Tracking

Trunk
1.0b1
Bug Flags:
blocking-calendar1.0 +

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Re-produce steps:
1. Build Thunderbird trunk code with lightning enabled (--enable-calendar)
2. Setup a IMAP account in Thunderbird and make sure lightning is enabled
3. Quit from TB
4. Setup a IMAP account in Evolution and select "Calendar" 
5. Quit from Evolution
6. Start TB again and login

Expected result:
TB UI can be used e.g. menu items

Actual result:
All the UIs haven't any response.

The root cause is 
A modal dialog window of "Lightning import data" exits. But it's invisible.
You can know this by type ALT+Tab keys
I think the Problem is that the dialog is there, but very small. I've seen this before often but never got around to filing a bug. Thanks for doing so!

The solution is to set a specific height/width on the wizard. This should be quite trivial. Boying, do you think you could create a patch for this bug?
Flags: blocking-calendar1.0+
Summary: Thunderbird hangs if evolution account exits → Migration wizard starts with very small width/height.
(Assignee)

Updated

10 years ago
Assignee: nobody → brian.lu
(Assignee)

Updated

10 years ago
Attachment #369026 - Flags: review? → review?(philipp)
Status: NEW → ASSIGNED
Comment on attachment 369026 [details] [diff] [review]
set specific width and height when opeing the dialog

r=philipp, but we need to set the dimensions also for mac. I'll fix this before checkin.

Thanks for the patch!
Attachment #369026 - Flags: review?(philipp) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/90b63564abcc>

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
OS: Linux → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → 1.0
The dialog is now set to a fixed size and can't be resized. 
Does this solution works for all localizations? 

Did you investigate what broke the dialog in Thunderbird in the first place? 
It used to work correctly with previous Lightning releases and it still works correctly in current Sunbird 1.0pre nightly test builds.
(Assignee)

Comment 6

10 years ago
(In reply to comment #5)
> 
> Did you investigate what broke the dialog in Thunderbird in the first place? 
> It used to work correctly with previous Lightning releases and it still works
> correctly in current Sunbird 1.0pre nightly test builds.

I don't know if this is a regression. The first place is at 
http://mxr.mozilla.org/mozilla-central/source/layout/base/nsDocumentViewer.cpp#3187

Compared with TB2 codes, Line 3187 and 3188 were added in TB3 trunk code
When TB starts, root is NULL so SizeToContent() returns without further processing.  That's why the dialog window's size is incorrect.
These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.