484161 - Qt breaks with enable-test in updater/test

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Anton Rogaynis (antonr)]

Attachment: fix

TestAUSReadStrings.cpp
c++ -o TestAUSReadStrings.o -c -I../../../../dist/include/system_wrappers -include /mnt/sdb/mozilla-central-qt/config/gcc_hidden.h -DAB_CD=en-US -DNS_NO_XPCOM  -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -I/mnt/sdb/mozilla-central-qt/toolkit/mozapps/update/test -I/mnt/sdb/mozilla-central-qt/toolkit/mozapps/update/src  -I/mnt/sdb/mozilla-central-qt/toolkit/mozapps/update/test -I.  -I../../../../dist/include   -I../../../../dist/include/test_update -I/mnt/sdb/mozilla-central-qt-obj/dist/include/nspr     -I/mnt/sdb/mozilla-central-qt-obj/dist/sdk/include    -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_anton -DTRACING -g3   -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -Wp,-MD,.deps/TestAUSReadStrings.pp /mnt/sdb/mozilla-central-qt/toolkit/mozapps/update/test/TestAUSReadStrings.cpp
c++   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DDEBUG -D_DEBUG -DDEBUG_anton -DTRACING -g3 -o TestAUSReadStrings TestAUSReadStrings.o   -lpthread          -Wl,-rpath-link,/mnt/sdb/mozilla-central-qt-obj/dist/bin -Wl,-rpath-link,/usr/local/lib -L../../../../dist/bin -L../../../../dist/lib ../../../../toolkit/mozapps/update/src/updater/readstrings.o  -lasound -ldl -lm     
c++: ../../../../toolkit/mozapps/update/src/updater/readstrings.o: No such file or directory
make[7]: *** [TestAUSReadStrings] Error 1
make[7]: Leaving directory `/mnt/sdb/mozilla-central-qt-obj/toolkit/mozapps/update/test'
make[6]: *** [libs] Error 2
make[6]: Leaving directory `/mnt/sdb/mozilla-central-qt-obj/toolkit/mozapps/update'

Comment 1

[Anton Rogaynis (antonr)]

Attachment: fix, adding readstrings.cpp for all platforms

Since readstrings.cpp used by all platforms, moving it up to CPPSRCS

Comment 2

[Robert Strong (they/them - no direct email)]

Comment on attachment 368250 [details] [diff] [review]
fix, adding readstrings.cpp for all platforms

Looks good and thanks

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-1.9.1
http://hg.mozilla.org/releases/mozilla-1.9.1/rev/99a0415dbd3a

I'll push this to mozilla-central once the tree is green

Comment 4

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/47c1f7c1c0d5